From owner-freebsd-acpi@FreeBSD.ORG  Fri Jul 13 08:16:25 2012
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 39C1A106566B;
	Fri, 13 Jul 2012 08:16:25 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 1F42A8FC15;
	Fri, 13 Jul 2012 08:16:23 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA03645;
	Fri, 13 Jul 2012 11:16:21 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1Spb2y-000ARj-SM; Fri, 13 Jul 2012 11:16:20 +0300
Message-ID: <4FFFD955.9030200@FreeBSD.org>
Date: Fri, 13 Jul 2012 11:16:21 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120620 Thunderbird/13.0.1
MIME-Version: 1.0
To: Vitaly Magerya <vmagerya@gmail.com>
References: <4FF95F79.30309@FreeBSD.org>
	<CAL409Ky6qmeBUaTeCqrRcvYEH+gDUqqUgvpFiKSCt2d361j64g@mail.gmail.com>
In-Reply-To: <CAL409Ky6qmeBUaTeCqrRcvYEH+gDUqqUgvpFiKSCt2d361j64g@mail.gmail.com>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@FreeBSD.org>,
	Giovanni Trematerra <gianni@FreeBSD.org>, John Baldwin <jhb@FreeBSD.org>
Subject: Re: improve cx_lowest logic
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2012 08:16:25 -0000

on 10/07/2012 19:30 Vitaly Magerya said the following:
> Andriy Gapon <avg@freebsd.org> wrote:
>> I would like to propose the following change for review and testing:
>> http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff
> 
> I just tested this on a laptop that jumps between reporting only
> C1, C1 and C2, and C1 through C3; in all cases your patch does
> the right thing, so this removes the need for kludges I had to
> do earlier; thank you, Andriy.
> 
> Will you also change how /etc/rc.d/power_profile selects
> lowest_value? It currently uses the maximum from dev.cpu.0.cx_supported,
> but with your patch it'll be the right thing to simply use Cmax.

I've put this on my to do list.  Hope to commit this trivial change soon-ish.

-- 
Andriy Gapon