From owner-freebsd-net@freebsd.org  Wed May 11 01:37:35 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F232B369B1
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Wed, 11 May 2016 01:37:35 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id 51C901DCF
 for <freebsd-net@freebsd.org>; Wed, 11 May 2016 01:37:35 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id 86F6F15222; Wed, 11 May 2016 01:37:34 +0000 (UTC)
Date: Wed, 11 May 2016 01:37:34 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D5872+325+9dea0574509cdbb3@reviews.freebsd.org
Subject: [Differential] D5872: tcp: Don't prematurely drop receiving-only
 connections
Message-ID: <56eb15d1f3565ca04fbef7c3c9c286e8@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-updated>,
 <differential-comment>
Thread-Topic: D5872: tcp: Don't prematurely drop receiving-only connections
X-Herald-Rules: <64>
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr>
X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi>
X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4>
X-Phabricator-To: <PHID-USER-dyyyzfp34mimhzvg33tk>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77>
X-Phabricator-To: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
X-Phabricator-Cc: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-Cc: <PHID-USER-x2wszzhtr5egla5eo3md>
X-Phabricator-Cc: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
Thread-Index: MmVmNzYzNzljOGQxMmM4MWI4MmNjYzcxMzczIFcyjN4=
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="b1_56eb15d1f3565ca04fbef7c3c9c286e8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.22
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2016 01:37:35 -0000


--b1_56eb15d1f3565ca04fbef7c3c9c286e8
Content-Type: text/plain; charset = "utf-8"
Content-Transfer-Encoding: 8bit

sepherosa_gmail.com updated this revision to Diff 16171.
sepherosa_gmail.com added a comment.


  Change if(..) {panic} into assertion and wrap the assertion using macro.

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D5872?vs=15642&id=16171

REVISION DETAIL
  https://reviews.freebsd.org/D5872

AFFECTED FILES
  sys/netinet/tcp_output.c

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, lstewart, hiren, transport, jtl
Cc: gnn, mike-karels.net, jtl

--b1_56eb15d1f3565ca04fbef7c3c9c286e8
Content-Type: text/x-patch; charset=utf-8; name="D5872.16171.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="D5872.16171.patch"

ZGlmZiAtLWdpdCBhL3N5cy9uZXRpbmV0L3RjcF9vdXRwdXQuYyBiL3N5cy9uZXRpbmV0L3RjcF9v
dXRwdXQuYwotLS0gYS9zeXMvbmV0aW5ldC90Y3Bfb3V0cHV0LmMKKysrIGIvc3lzL25ldGluZXQv
dGNwX291dHB1dC5jCkBAIC0xMzAsNiArMTMwLDE2IEBACiAJJlZORVRfTkFNRSh0Y3BfYXV0b3Nu
ZGJ1Zl9tYXgpLCAwLAogCSJNYXggc2l6ZSBvZiBhdXRvbWF0aWMgc2VuZCBidWZmZXIiKTsKIAor
LyoKKyAqIE1ha2Ugc3VyZSB0aGF0IGVpdGhlciByZXRyYW5zbWl0IG9yIHBlcnNpc3QgdGltZXIg
aXMgc2V0IGZvciBTWU4sIEZJTiBhbmQKKyAqIG5vbi1BQ0suCisgKi8KKyNkZWZpbmUgVENQX1hN
SVRfVElNRVJfQVNTRVJUKHRwLCBsZW4sIHRoX2ZsYWdzKQkJCVwKKwlLQVNTRVJUKCgobGVuKSA9
PSAwICYmICgodGhfZmxhZ3MpICYgKFRIX1NZTiB8IFRIX0ZJTikpID09IDApIHx8XAorCSAgICB0
Y3BfdGltZXJfYWN0aXZlKCh0cCksIFRUX1JFWE1UKSB8fAkJCQlcCisJICAgIHRjcF90aW1lcl9h
Y3RpdmUoKHRwKSwgVFRfUEVSU0lTVCksCQkJCVwKKwkgICAgKCJuZWl0aGVyIHJleG10IG5vciBw
ZXJzaXN0IHRpbWVyIGlzIHNldCIpKQorCiBzdGF0aWMgdm9pZCBpbmxpbmUJaGhvb2tfcnVuX3Rj
cF9lc3Rfb3V0KHN0cnVjdCB0Y3BjYiAqdHAsCiAJCQkgICAgc3RydWN0IHRjcGhkciAqdGgsIHN0
cnVjdCB0Y3BvcHQgKnRvLAogCQkJICAgIGxvbmcgbGVuLCBpbnQgdHNvKTsKQEAgLTE1NDUsOSAr
MTU1NSw3IEBACiAJCQl0cC0+dF9zb2Z0ZXJyb3IgPSBlcnJvcjsKIAkJCXJldHVybiAoZXJyb3Ip
OwogCQljYXNlIEVOT0JVRlM6Ci0JICAgICAgICAgICAgICAgIGlmICghdGNwX3RpbWVyX2FjdGl2
ZSh0cCwgVFRfUkVYTVQpICYmCi0JCQkgICAgIXRjcF90aW1lcl9hY3RpdmUodHAsIFRUX1BFUlNJ
U1QpKQotCSAgICAgICAgICAgICAgICAgICAgICAgIHRjcF90aW1lcl9hY3RpdmF0ZSh0cCwgVFRf
UkVYTVQsIHRwLT50X3J4dGN1cik7CisJCQlUQ1BfWE1JVF9USU1FUl9BU1NFUlQodHAsIGxlbiwg
ZmxhZ3MpOwogCQkJdHAtPnNuZF9jd25kID0gdHAtPnRfbWF4c2VnOwogCQkJcmV0dXJuICgwKTsK
IAkJY2FzZSBFTVNHU0laRToKCg==


--b1_56eb15d1f3565ca04fbef7c3c9c286e8--