From owner-freebsd-current@FreeBSD.ORG Fri Aug 7 20:54:36 2009 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 535271065670 for ; Fri, 7 Aug 2009 20:54:36 +0000 (UTC) (envelope-from oberman@es.net) Received: from mailgw.es.net (mail4.es.net [IPv6:2001:400:6000:6::2]) by mx1.freebsd.org (Postfix) with ESMTP id 086C88FC0A for ; Fri, 7 Aug 2009 20:54:35 +0000 (UTC) Received: from ptavv.es.net (ptavv.es.net [IPv6:2001:400:910::29]) by mailgw.es.net (8.14.3/8.14.3) with ESMTP id n77KsXG9014190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 7 Aug 2009 13:54:34 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 8FA4D1CC31; Fri, 7 Aug 2009 13:54:32 -0700 (PDT) To: "b. f." In-reply-to: Your message of "Thu, 06 Aug 2009 11:37:50 -0000." Date: Fri, 07 Aug 2009 13:54:32 -0700 From: "Kevin Oberman" Message-Id: <20090807205432.8FA4D1CC31@ptavv.es.net> X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2009-08-07_10:2009-07-24, 2009-08-07, 2009-08-07 signatures=0 Cc: freebsd-current@FreeBSD.org Subject: Re: Unable to build HEAD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2009 20:54:36 -0000 > Date: Thu, 6 Aug 2009 11:37:50 +0000 > From: "b. f." > > On 8/6/09, Kevin Oberman wrote: > >I have tested a patch from bf and it works. I've asked if he wants to > >submit the PR or if he wants me to. If I don;t hear from him, I'll > >submit tomorrow. > > Slightly revised and augmented patch is in: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=137483 I think the patch is right, but I am still broken. I also had to remove the ".if ${MK_OPENSSH) != "no" and paired ".endif" from /usr/src/lib/libpam/modules/modules.inc. Once this was done, it looks like everything is correct. I think the right answer is to either unconditionally build the pam module or to add an option that is specific to the module. I think the former is really the way to go as the module only adds 46K to the system and, if you build without OpenSSH, you are either building an embedded system where you will almost certainly be trimming a lot further than the src.conf file allows, or because you are using the version from ports. If the latter, you almost certainly WILL want pam_ssh. And thanks for fixing the Makefile and submitting the PR! -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751