From owner-freebsd-ppc@freebsd.org Mon Mar 6 22:01:10 2017 Return-Path: Delivered-To: freebsd-ppc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F39D0D00503 for ; Mon, 6 Mar 2017 22:01:10 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-196.reflexion.net [208.70.211.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9A8391367 for ; Mon, 6 Mar 2017 22:01:09 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 1862 invoked from network); 6 Mar 2017 22:01:54 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 6 Mar 2017 22:01:54 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v8.30.2) with SMTP; Mon, 06 Mar 2017 17:01:08 -0500 (EST) Received: (qmail 15088 invoked from network); 6 Mar 2017 22:01:08 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 6 Mar 2017 22:01:08 -0000 Received: from [192.168.1.111] (c-67-170-167-181.hsd1.or.comcast.net [67.170.167.181]) by iron2.pdx.net (Postfix) with ESMTPSA id 9153AEC7C1F; Mon, 6 Mar 2017 14:01:07 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: powerpc64 head -r314687 (PowerMac G5 so-called "Quad Core", clang based): CAM status: Command timeout (always?) From: Mark Millard In-Reply-To: <466C25ED-0A70-4988-9BB1-3B43BD031E5E@dsl-only.net> Date: Mon, 6 Mar 2017 14:01:06 -0800 Cc: FreeBSD PowerPC ML , Justin Hibbits , Nathan Whitehorn Content-Transfer-Encoding: 7bit Message-Id: References: <98A62E0D-C2A0-40B1-AE6D-5810906208AE@dsl-only.net> <4C78F6AA-5ABD-4445-B5EF-4E6778CE36FE@dsl-only.net> <20170306164341.GA83069@wkstn-mjohnston.west.isilon.com> <466C25ED-0A70-4988-9BB1-3B43BD031E5E@dsl-only.net> To: Mark Johnston X-Mailer: Apple Mail (2.3259) X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 22:01:11 -0000 [scsi_pass.c -r314624 is the problem file vintage of the two files.] On 2017-Mar-6, at 10:36 AM, Mark Millard wrote: > On 2017-Mar-6, at 8:43 AM, Mark Johnston wrote: > >> On Mon, Mar 06, 2017 at 02:05:39AM -0800, Mark Millard wrote: >>> On 2017-Mar-6, at 1:37 AM, Mark Millard wrote: >>> >>>> When I tried to jump from head -r314479 to -r314687 the -r314687 kernel >>>> the result failed by always(?) getting: >>>> >>>> CAM status: Command timeout >>>> >>>> for: >>>> >>>> ATAPI_IDENTIFY >>>> INQUIRY >>>> DSM TRIM >>>> READ_DMA48 >>>> SETFEATURES ENABLE RCACHE >>>> WRITE_DMA48 >>>> etc. >>>> >>>> at: >>>> >>>> ada0:ata2:0:0:0 >>>> aprobe0:ata0:0:0:0 >>>> >>>> Booting with the older -r314479 works fine (same -r314687 world). >>>> >>>> [FYI: It is a ufs context.] >>>> >>>> >>>> The only thing that looks likely to me for >>>> the change in behavior is. . . >>>> >>>> Author: markj >>>> Date: Fri Mar 3 20:51:57 2017 >>>> New Revision: 314624 >>>> URL: >>>> https://svnweb.freebsd.org/changeset/base/314624 >>>> >>>> >>>> Log: >>>> Reject userland CCBs that have CAM_UNLOCKED set. >>>> >>>> CAM_UNLOCKED is internal flag and cannot correctly be set by userland. >>>> Return EINVAL from CAMIOCOMMAND and CAMIOQUEUE if it is set. >>>> >>>> Also fix leaks in some of the error paths for CAMIOQUEUE. >>>> >>>> PR: 215356 >>>> Reviewed by: ken, mav >>>> MFC after: 1 week >>>> Differential Revision: >>>> https://reviews.freebsd.org/D9869 >>>> >>>> >>>> Modified: >>>> head/sys/cam/cam_xpt.c >>>> head/sys/cam/scsi/scsi_pass.c >>>> >>>> >>>> >>>> [This may just mean that it exposes other problems.] >>> >>> Yep: reverting the two files allowed the PowerMac G5 so-called >>> "Quad Core" to boot fully and I could log in. >> >> Do you have a full dmesg of the failed boot? Am I correct in thinking >> that the boot failed before making it to user mode? > > . . . >> If so I'm rather >> puzzled, as the change should only affect userland applications. >> Specifically, it modified a couple of ioctl handlers. >> >>> >>> It appears that if such powerpc64 machines are to stay bootable >>> then other things need to be cleaned up before the two updated >>> files from -r314624 should be used. >>> >>> Should the 2 files be reverted until other things are cleaned up? >> >> I don't mind reverting the change, but my suspicion is that it uncovered >> a problem rather than introducing it. If you're willing to narrow things >> down a bit, could you try booting with one of the file modifications and >> not the other? They are independent. > > In a while I'll try each of the files individually, one old, one modern > each time. scsi_pass.c -r314624 (new) and cam_xpt.c -r314283 (old): fails. cam_xpt.c -r314624 (new) and scsi_pass.c -r308451 (old) : works fine so far. Prior results: cam_xpt.c and scsi_pass.c both being -r314624 (both new): fails cam_xpt.c -r314283 and scsi_pass.c -r308451 (both old): works fine. [I omit the segment of the /var/log/messages file that I sent last time.] === Mark Millard markmi at dsl-only.net