From nobody Fri May 17 17:42:56 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VgvSK1Jg8z5LWVG; Fri, 17 May 2024 17:42:57 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VgvSK0hnHz4djh; Fri, 17 May 2024 17:42:57 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715967777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=92X9idhCKFiYLOZ1RW7YC5iTmMEY5/SGTFODtzz31Cs=; b=rQWl25CnNzzcuqxV/iLwevoxanHtoqsPaAmZlsTJZYk7FU1FORkB7lDOAj73z/+LLzDqMk bk/AGmQmkiXkGBJriJaRU1M6Ncsndkvi7zceYQbOoNHJ+pZz/+jm8S4eBjc2EMzo1Y8n7j 94hKk+0glXP327FoOqFagNO58+mt6ju5LGeQ/HbzmcOfGgwX43CabIalmMsfBtV1I+7Vw6 bAP7CauZOxZBtaoU3Cgfz4yzipkUZn8zjPaIp9gs9o3O3NTdVTOMsDlyAzO5Cf16XJrpDy gheck+Je7pl+v+kLP4rMy+aK/DLB3PoKWA2+kMsmWX4fMxM2E+Y/b0STqM38mA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715967777; a=rsa-sha256; cv=none; b=g1RAKnzaiZUAZXiVMA2Mm1NtzDXNgnLFtNZiCt39aQGTEkVc8Hgd1nO4zxQq8GOr+upxdg PL+alp2CNLYMJsL2pagWXuGO2j/hrIPh6heZDyfngnbPw4U2VZW7v0gmkMbjczZ4zdI3kD 4KPY7uIYFOrUMMvJ31XK2Y1GpCEf3vIhFN/4GQ7TiDib/hl02aa9UYDxC7XYOuLP4cuHYf Uu6D/RO/kx92c0Q6DLOqZkaDFC6trm/jLyyWpbD//PTcGXuVgucJA3J2uSLyb/aMlSzXYr XDEIdmuFvkoqOPsYgRhCFRavMwi+JcapVU7MGwNjDtLBQP1F71ZBMmaxdtCF5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715967777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=92X9idhCKFiYLOZ1RW7YC5iTmMEY5/SGTFODtzz31Cs=; b=ugs4IMm62uRccQWrBj0EZo5b4Cq0Ylhg45Dj3ZHkYcDXeH1e/fISwhmTZrjxSOUMZrvVua AuXCTD2iUHalhAMAcIYO7za7VxUJdrH4X7seK6EzO80anT8jESt3d92uM3bCqCARFhzcM6 QRjiDqLY4StR7P3UyVb7ppfY7XczrzbcLXPFdBsJv1Y3piqhjyDerrrV+j23Mx8yNSWTol gy47X4LyB7hNjYOdvMPLPP9JxwraFOPq/eVkvlsC1TSys6s+OUTo38Sti7HJnLJizgFWwk l40m0f08GHqIV3WSWG3GI4T4l5vcfau98jEgZ9WSk/f/eKQpuy3GqgY4rafjCg== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VgvSK06V4zJs6; Fri, 17 May 2024 17:42:56 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id A54493C019B; Fri, 17 May 2024 17:42:56 +0000 (UTC) Date: Fri, 17 May 2024 17:42:56 +0000 From: Brooks Davis To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4c0dfd5959bd - main - arm: fail early on gcc builds Message-ID: References: <202405171601.44HG1Sef047261@gitrepo.freebsd.org> <456e4eef-e194-4e32-b3a7-c93bb941b82b@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 17, 2024 at 04:27:14PM +0000, Brooks Davis wrote: > On Fri, May 17, 2024 at 09:14:46AM -0700, John Baldwin wrote: > > On 5/17/24 9:01 AM, Brooks Davis wrote: > > > The branch main has been updated by brooks: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c0dfd5959bd499754e3fc9a7ce37c1d5ece31f7 > > > > > > commit 4c0dfd5959bd499754e3fc9a7ce37c1d5ece31f7 > > > Author: Brooks Davis > > > AuthorDate: 2024-05-17 15:47:22 +0000 > > > Commit: Brooks Davis > > > CommitDate: 2024-05-17 16:01:19 +0000 > > > > > > arm: fail early on gcc builds > > > Since at least 2022 (see https://reviews.freebsd.org/D36754), it has > > > not been possible to build armv6/armv7 with gcc due to atomics macros > > > gcc doesn't like. Prevent developers doing due diligance from wasting > > > time and CPU cycles on this combination as it just fails to build in > > > libc. > > > Reviewed by: imp, andrew > > > Differential Revision: https://reviews.freebsd.org/D45193 > > > > As I said in the review, this is a weird change. Only amd64 and i386 build > > with GCC. You should blacklist all the others if you are going to blacklist > > any, not just 32-bit arm. I hadn't blacklisted any to make it possible for > > other developers to work on it. Also, the review in question is probably not > > the right fix, it's probably that we need to pass different CFLAGS to GCC for > > 32-bit arm. > > I think I misunderstood your point in the review. I've wasted days > trying to do the right thing to let me reapply 4510f2ca9170 (Make > WITHOUT_UNDEFINED_VERSION the default) only to find that it's secret > knowledge that gcc builds are broken except on x86. > > IMO there's less than zero value in universe targets that don't work > unless they are clearly fenced. > > I propose disabling all the others and adding a flag to ignore this > guard. I've implemented this in https://reviews.freebsd.org/D45230 -- Brooks