From owner-svn-ports-all@FreeBSD.ORG Tue Jul 2 23:09:31 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 58A3CB91; Tue, 2 Jul 2013 23:09:31 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) by mx1.freebsd.org (Postfix) with ESMTP id 34C911B30; Tue, 2 Jul 2013 23:09:31 +0000 (UTC) Received: from projector.lan (dhcp-108-170-169-8.cable.user.start.ca [108.170.169.8]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id A114811F805; Tue, 2 Jul 2013 19:00:48 -0400 (EDT) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: svn commit: r321982 - in head/net: . hanstunnel hanstunnel/files From: Adam Weinberger In-Reply-To: Date: Tue, 2 Jul 2013 19:00:46 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <2F9D29C1-259B-41F0-9C67-00AAE5DBA69E@adamw.org> References: <201306282045.r5SKjaZb090161@svn.freebsd.org> <20130701011908.GB9325@FreeBSD.org> To: Felippe de Meirelles Motta X-Mailer: Apple Mail (2.1508) Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2013 23:09:31 -0000 On 2013-07-01, at 13:30, Felippe de Meirelles Motta = wrote: > danfe@, bsam@ and others thanks for the points mentioned, some I had = noticed, others I had really missed, but I just could not manipulate the = outcome of the patches without proper approval of the maintainer, = because this is your role. Sorry but I totally disagree. As committers, we (supposedly) know what = is best, and the right way to do things. External maintainers are = submitters; they can make mistakes and you can catch and fix them, = within reason. On the whole, people are quite appreciative when you = commit their patch quickly with small modifications, rather than = dragging the PR for weeks while you wait for a spelling fix. I mean, don't go changing the logic or anything, but all the time I = close PR's with "Committed, but I fixed MASTER_SITE to use the source = forge macro" or whatever. Never once have I heard anything except "Thank = you," and best of all, next time they submit a PR they get it right. I really don't understand why you'd rather commit something you know to = be wrong. DTRT and don't be a pedant. # Adam =20 -- Adam Weinberger adamw@adamw.org http://www.adamw.org