From owner-freebsd-hackers  Fri Jul 23  8:38:55 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP
	id 7B8B215119; Fri, 23 Jul 1999 08:38:36 -0700 (PDT)
	(envelope-from dwmalone@maths.tcd.ie)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa04534@salmon>; 23 Jul 1999 16:37:21 +0100 (BST)
Date: Fri, 23 Jul 1999 16:37:20 +0100
From: David Malone <dwmalone@maths.tcd.ie>
To: Dag-Erling Smorgrav <des@flood.ping.uio.no>
Cc: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>,
	Sheldon Hearn <sheldonh@uunet.co.za>,
	Brian Feldman <green@FreeBSD.org>, hackers@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c inetd.h
Message-ID: <19990723163720.A15697@walton.maths.tcd.ie>
References: <41604.932732959@axl.noc.iafrica.com> <xzpn1wnbj6p.fsf@flood.ping.uio.no> <19990723153416.F10047@internal> <xzplnc7bia3.fsf@flood.ping.uio.no> <19990723155348.J10047@internal> <xzpiu7bbha8.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95.6i
In-Reply-To: <xzpiu7bbha8.fsf@flood.ping.uio.no>; from Dag-Erling Smorgrav on Fri, Jul 23, 1999 at 03:57:19PM +0200
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


I've found the problem - it looks like a bug in the code for matching
internal service names to /etc/service names. The code says:

                        if ((bi->bi_socktype == sep->se_socktype &&
                            strcmp(bi->bi_service, sep->se_service) == 0) ||
                            matchservent(bi->bi_service, sep->se_service,
                            sep->se_proto))

It should probably say:

                        if (bi->bi_socktype == sep->se_socktype &&
                            ((strcmp(bi->bi_service, sep->se_service) == 0) ||
                            matchservent(bi->bi_service, sep->se_service,
                            sep->se_proto)))

It was running the tcp service instead of the udp service.

	David.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message