From owner-svn-src-head@FreeBSD.ORG  Fri Feb 27 08:46:25 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 81B01395; Fri, 27 Feb 2015 08:46:25 +0000 (UTC)
Date: Fri, 27 Feb 2015 08:46:25 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Andrew Rybchenko <arybchik@FreeBSD.org>
Subject: Re: svn commit: r279351 - head/sys/dev/sfxge
Message-ID: <20150227084625.GA72768@FreeBSD.org>
References: <201502270739.t1R7dAiK016165@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201502270739.t1R7dAiK016165@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2015 08:46:25 -0000

On Fri, Feb 27, 2015 at 07:39:10AM +0000, Andrew Rybchenko wrote:
> New Revision: 279351
> URL: https://svnweb.freebsd.org/changeset/base/279351
> 
> Log:
>   sfxge: expect required init_state on data path and in periodic calls
>   
>   With the patch applied the number of instruction events is 1% less and
>   number of mispredicted branch events is 5% less under multistream TCP
>   traffic load close to line rate.

Yuck.  This brings more Linux' stink to our code.  Why compiler can't do
this itself?  From what I see, __predict_false was added to != checks, and
__predict_true for == ones.  Looks like a pattern to me...

./danfe