From owner-cvs-all  Wed Jan 24 23:39:53 2001
Delivered-To: cvs-all@freebsd.org
Received: from harmony.village.org (rover.village.org [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP
	id 38D3D37B400; Wed, 24 Jan 2001 23:39:28 -0800 (PST)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.1/8.11.1) with ESMTP id f0P7d6966140;
	Thu, 25 Jan 2001 00:39:06 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Message-Id: <200101250739.f0P7d6966140@harmony.village.org>
To: Peter Wemm <peter@netplex.com.au>
Subject: Re: cvs commit: src/sys/i386/isa if_ar.c if_arregs.h src/sys/pci if_ar_p.c 
Cc: John Hay <jhay@icomtek.csir.co.za>, jhay@FreeBSD.org (John Hay),
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-reply-to: Your message of "Wed, 24 Jan 2001 23:33:17 PST."
		<200101250733.f0P7XH490063@mobile.wemm.org> 
References: <200101250733.f0P7XH490063@mobile.wemm.org>  
Date: Thu, 25 Jan 2001 00:39:06 -0700
From: Warner Losh <imp@harmony.village.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <200101250733.f0P7XH490063@mobile.wemm.org> Peter Wemm writes:
: This is bikeshed material, but NetBSD put things like that in dev/ic/*.

True :-)

: the other includes, and any common C code that is shared between drivers
: (eg: some 3com stuff) as well.

Ah yes.  The elink problem.

I'm also running into the same problem with some code I'm working on
for the pccard ExCA interface that is implemented by ISA pcmcia bridges,
PCI pcmcia bridges and PCI CardBus bridges.  So this code would be
used by both pcic (isa and pci) and pccbb.  Not all pcmcia bridges
implement this interface (the pcic98 bridge as well as the tcic
parts), so putting it in dev/pccard seems incorrect.

: If there was a common components there could be, for example:
: dev/common/hd64570.h
: dev/common/hd64570.c
: 
: Can anybody not live with this?  ie: dev/common ?
: Userland could #include <dev/common/if_wavelan_ieee.h>.

I can live with that, and think it is better than anything I can think
of.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message