From nobody Thu Oct 31 23:37:12 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfgQF68bGz5b86L for ; Thu, 31 Oct 2024 23:37:25 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfgQF4GjQz46Pn for ; Thu, 31 Oct 2024 23:37:25 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-83ab21c269eso56561839f.2 for ; Thu, 31 Oct 2024 16:37:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730417845; x=1731022645; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ru7DcO1lCaZCw9jLPgiqwNI/npZuaeSLuQc00yAiANI=; b=OXoWzb2YluH9t5SsblIG8LK6O/JOd0sV8tAIIiuiJKESDEHzOdkRwWzNT19OWU9qZC Ilrqhy9/mBB4WGEBimuWabT6iJHA8PvE7+KS2S2TYVfYRiDGii+zePUfrXHrraqDLvzr h6zD0chWKkksGZpvkZvPxfclJvkpP4QDmRFt7Twwdz8evUJxKkJtmp6iYEwztfYTbLTP z5J6S6P//AbdaIUKQrKmoZuQZf83QRMGHIsgnDLgr+xk2wW6PQ0iseHDVi21pWdIzlDp 2zRCaATkaix5iSGXrvAOkKjo2tH4ZrnMw0gdgzi/Aqh+E116Rm/SV7wIhU78DzkWqO7s lgIw== X-Gm-Message-State: AOJu0Yx4IskyzLYxCKYJ6GMRcHt2NakXSLjSQOcaPeEWBL1vDQH6BwAJ JC7nmHEVl7Zg38TV6V0Pbfdtnf3hgY+s2HZ50NKD0ipaa1/TdoUrR2KD2WK/Xp+Tb3VS3WIkIR2 tpBnPtuLzFhoUxaTs/ltOhIg0CH8= X-Google-Smtp-Source: AGHT+IHCsE8/wFAAZVQp3S95RRgTORbpUyjHLUYE9qLmcqzT3nTquQeU3FIM5O/lFGyg3lqPOTsFxbzWgw3iyiHQZr4= X-Received: by 2002:a05:6e02:1c2a:b0:3a4:e99a:bd41 with SMTP id e9e14a558f8ab-3a6b02be160mr19058215ab.12.1730417844641; Thu, 31 Oct 2024 16:37:24 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <7FF78752-80EB-47CA-9E60-515607D3CFE5.ref@yahoo.com> <7FF78752-80EB-47CA-9E60-515607D3CFE5@yahoo.com> In-Reply-To: <7FF78752-80EB-47CA-9E60-515607D3CFE5@yahoo.com> From: Ed Maste Date: Thu, 31 Oct 2024 19:37:12 -0400 Message-ID: Subject: Re: git: cf1aba2857c1 - main - freebsd-update: refuse to operate on a pkgbase system To: Mark Millard Cc: dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4XfgQF4GjQz46Pn X-Spamd-Bar: ---- On Thu, 31 Oct 2024 at 15:17, Mark Millard wrote: > > > + # Presence of FreeBSD-* package(s) indicates packaged base. > > + if ! pkg -c ${BASEDIR} info -q -x '^FreeBSD' 2>/dev/null; then > > Slight difference in the comment vs. the code's behavior? : > > Comment: FreeBSD-* > Code: FreeBSD* The code is a regex ^FreeBSD while I wrote the comment thinking of a shell glob - it's fine that they're not identical (except for this confusion). That said there is room for improvement here - we'll want to detect pkgbase installs in downstream projects that use a different package naming scheme (e.g. packages starting with CheriBSD). I'll keep a note of this comment for any potential iteration on this.