From owner-dev-commits-src-main@freebsd.org Sat May 15 21:28:12 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 050F962879A for ; Sat, 15 May 2021 21:28:12 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic304-25.consmr.mail.gq1.yahoo.com (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FjJQy6cGMz3vly for ; Sat, 15 May 2021 21:28:10 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1621114089; bh=sCmR1QjB7mtYXUqm7t1kuZl7yDH22Tb9jszA5UeTa9P=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=FQwM84yMNXwS97JsS1zzOADjfyfodNdQAfhWYVjv9qfPLvrRdENmDp18CJNGCIwHxfmGez7mzhjinRafwVhlF9UnkoqH2mkFznb5IZ1sSqDHPOIhBos2SjmR58AK5Fd81f+aigqD6petAb0zwbAPF5vUEiarU8Ve6VJq/9ga4oVoxjocJXptN7E0RWcRRhgerI1+vT+KJnqglfaFfFVc2iUZEDGjoRS0FeqdYitYkC2y9kuRbHIejNiYKiFpuz8GaN167pYw16NNLdXT6D9xIxGXTkZ3UqTIDr/fWwIOuOvft+0QIjJKHjcRMeQ6hP3h+0X5tCChvynj1wuaJGd6ZA== X-YMail-OSG: 5O.imfoVM1npih_DZUw.nyMqdBUTJryiJdlhk_ffMQMSUby41.zKN6ba5a.0pf0 w5mQYhA2lCqrLnkvsPd0xIbLvjp1WVfK2VUegL1NQ2Tqn6mba5u9aZGRQbgT9QnAhiRZIi.hYhO8 _OX2iFPCKppWbH2Jut0boSHxP49dn8wioRRHLmGc5V_u04M5l7hiuvyBEOnW89yloWHxAM77PrUM RK9Xc8Yd51aEiKjZtM7.BUsfShtMGvcji8ZV2kovyg.Lbo9kooy.fx0lA5VSo7DX0C8.jZy36aSB M1MfrfLAJA0RZBoprkNeYWI0crvIUJmL9aKdxU1btDHO_gJe_GvnSa7Q.a5YfThcAHs0x4AVAKds bfr_0pe49RV_BMG0iIJRIj3PF5AhU_.mmtlS25DvxKWyNgOdcRGibP6GSZhpEpIQuFZGBTOndk2J pL8LFaezM0WyE5SVnTN5kur0alzNXf40OlMSdgL1cH7.co4QoFl5RqvnfeS9euo9foRYUHfAd1UQ wJXha5wu9fm8vWuHiLqWFgQB9gnEFnelNuQ19FAiUSZfkbe8nzsQXV1NxH.vjCKCijS1wuK97pMi rt7Z5VROJ.4WhKPaYUVdPq9eUnoar5KG27J1yaA0N6FIUXCl4r0qqCeZyjbNerogXCQrPy4If0lB wqZf29FQsTTEA_8WZaecWtprFEMpeC5uDOlQZLiFFCOwT3EC3wCfRmdsPFNcIQRgYn_tM1enDgGz kojA7j_TNkJKklHMXhQa13J_c0FUqGY6dqy56neuSDT2UJp7kqtyl1TDPJ5XjMTb6gqGYk6sbdi6 959Wz5VvSFx_eDrQ5F0R45yS1tuAzNSYetOpJ83rJK_XDQkNhDhhXYKQOWbITYAZ45vOWCdScbMP PMqNxfhuaNUukiNRHDaVoTDsJGImNvTjP7qZjCR32JVzE6J5woShuznBubhMXLL0CdBgdSYbqPwS 0FJTflfEEHGXmD5cJxQbpErHtVAIwJ4_ck8VcVK55y.SgBopcTZTPzH60GO6Qi2wH1PC13M18jNf fbMAfb_JbKgH2bhnxhpBvfKp90065f9rLlFR6.4HGCdUVDy4mGErZCrnVVZAmqLkFvXuWWZIH1H. IjO2s7EYICiyiZASW0eoKiEJG4NXB2tI6hqMefJud8Mw7sdFRRpXuG0nzZ0b.q6lSWvbD3i7LfMa q88wVSVawezTKG4lR6dF.H8ZiSLZqqdCJlgEXJEY5GGlAZNmXw8IbYXIRfx0qrQEdgFpD63SPghy KvUNuFWCFQc7jryXPfcNqoHoxspPR5ePW0bgzMrOr0aEGbfPWD2kGkVtpq8PCtidilMzvf7nSFs9 R7PPCug8rWfEMPTP4qKYq6FsKG_Trbv.1ChcxO9W0Ysr3TKvkiTiNSuSqdb.MqMWXqEP0jO_tuwk R8bjElroDvXH98AtTWyyBRqA3_pMX8b.59ljURBc3mvHqbCLdLB41cL_37TnqZlKVINJ78cRUhKh 3CUiC2T6EppRuoxDaaEscwUgwZ3K1fPKwxXfLV.VAKb6YDVoWS8JAZp_q927M.e9Ka1wXKSDdV7F K44Ape256BhUFDbAqaNKmRieCGf0PebQ5S.kh8lYrk0c.fYv2Ha1MJKOeEs8VNz2OILPp6m7w0M4 WkhwtUthZ1kMY.GlENbuILA5nLAD9ISW6ZHiJtqW.RXEbOGsiOUwb.qIt8X.8KsiV6XaIm0kXO0w 63GNgd1dbL92ZSzglOQ9aGZDeKA3uIK9F8VwgQIkt0EmzweergOnXXVI2em5NFRwW2w2WRX79xxl vkJPhA81CS.qZcqQcWuQzieznv8ZMpl1N4freID7vaTAVMIIF.a.l3GYqykWd4cSMpMER_JJmbv. cLuwqzvjbSaFYTgZsHlfoSOwAF.T7TzCRydwtDi4wo7snvK.cFkoF1ZO0IVELfvGD2qKyJqRUXwK p4PHnsrpxqUDyVJ1IazvCFKr09WEslLEKivxZrk_3tLJOhmXjLPDnZU1uOqL59jPr_Hqpw10AI68 25vpQaXCuDRpsELVfNjbs3N1xz5z8jlr43Owu6h_Shib2yiMdMxvuppMFZZiwpCtY93doonOuQUN U8iBSCwz_251x7C8DqTlIa1Isb10VyZAvh9gRjNw6ZZoPfaSDeLIoVQ6YA6EDqHcQjCVUN4jjjSk 0wtuStC4fRMBXEfwC0aTxQua4k8QenqKSiSsqAdvzKnLq2bi8gy0.XVUrcJxR42nkgSkFCCrWhR7 jeNLYg2sFyJBGtoDWEjet6QHWqxcXae8Pqdk_Ll3YzyYolkDvyOS6UsA3usQKZDkXbYbSJj_LuTv cY.xlu7rXpAjvN_KVTNwt7P0MsrF7IySFquVqbEws24UMZ04TT5F2.W1n8GhpNxgDuR2ThhLam7Y f9sJrGaJsMpOQVkCjc4v3idlYD.QPmV1wm9ZmPWkr9aYTlvSufCS3mz7cokRw1MJtn7N56hSpdBU KP9GGr97Yl.VYOHH5939T2CLBHg8- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Sat, 15 May 2021 21:28:09 +0000 Received: by kubenode547.mail-prod1.omega.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 33cceacc3dd67f1f7f69288ec56db454; Sat, 15 May 2021 21:28:08 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-Id: Date: Sat, 15 May 2021 14:28:05 -0700 To: Konstantin Belousov , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3654.80.0.2.43) References: X-Rspamd-Queue-Id: 4FjJQy6cGMz3vly X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.68.206:from]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.68.206:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.206:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.68.206:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 May 2021 21:28:12 -0000 Konstantin Belousov kostikbel at gmail.com wrote on Sat May 15 19:42:08 UTC 2021 : > On Sat, May 15, 2021 at 07:01:07AM +0000, Lutz Donnerhacke wrote: > > . . . > > +static int > > +IcmpAliasIn1(struct libalias *la, struct ip *pip) > > +{ > > + LIBALIAS_LOCK_ASSERT(la); > > struct alias_link *lnk; > > struct icmp *ic; > And this is not in style. Declarations must precede executable = statements, > even asserts. Looks like the "may be placed" wording in "man 9 style" below might need adjustment in the first paragraph quoted. The beginning of a function is an example of a block and I got a rather different interpretation of the wording out of reading the material as it is: I read it as indicating an optional status for such a placement of declarations in blocks generally. QUOTE When declaring variables in functions declare them sorted by size, = then in alphabetical order; multiple ones per line are okay. If a line overflows reuse the type keyword. Variables may be initialized = where declared especially when they are constant for the rest of the = scope. Declarations may be placed before executable lines at the start of = any block. Calls to complicated functions should be avoided when initializing variables. . . . Do not insert a blank line at the beginning of functions with local variables. Instead, these should have local variable declarations = first, followed by one blank line, followed by the first statement. END QUOTE In the second paragraph quoted, the "should have" possibly should be "must have". Having read the other wording first, and misinterpreted, I apparently read too much optionality into "should have" as well. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)