From owner-cvs-all  Sun Feb  3 14:40:21 2002
Delivered-To: cvs-all@freebsd.org
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170])
	by hub.freebsd.org (Postfix) with ESMTP
	id A5A0B37B41C; Sun,  3 Feb 2002 14:40:15 -0800 (PST)
Received: (from uucp@localhost)
	by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g13Me9b24160;
	Sun, 3 Feb 2002 22:40:10 GMT
	(envelope-from mark@grondar.za)
Received: from greenpeace.grondar.org (greenpeace [192.168.42.2])
	by gratis.grondar.org (Postfix) with ESMTP
	id A8EF510; Sun,  3 Feb 2002 22:39:28 +0000 (GMT)
Received: from grondar.za (localhost [127.0.0.1])
	by greenpeace.grondar.org (8.11.6/8.11.6) with ESMTP id g13MdRE72311;
	Sun, 3 Feb 2002 22:39:27 GMT
	(envelope-from mark@grondar.za)
Message-Id: <200202032239.g13MdRE72311@greenpeace.grondar.org>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpam/modules/pam_lastlog pam_lastlog.c src/lib/libpam/modules/pam_login_access login_access.c pam_login_access.c pam_login_access.h src/lib/libpam/modules/pam_securetty pam_securetty.c src/lib/libpam/modules/pam_unix pam_unix.c 
References: <xzpr8o2p6n4.fsf@flood.ping.uio.no> 
In-Reply-To: <xzpr8o2p6n4.fsf@flood.ping.uio.no> ; from Dag-Erling Smorgrav <des@ofug.org>  "03 Feb 2002 23:01:03 +0100."
Date: Sun, 03 Feb 2002 22:39:22 +0000
From: Mark Murray <mark@grondar.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> Mark Murray <markm@FreeBSD.org> writes:
> > markm       2002/02/03 07:17:57 PST
> > 
> >   Modified files:
> >     lib/libpam/modules/pam_lastlog pam_lastlog.c 
> >     lib/libpam/modules/pam_login_access login_access.c 
> >                                         pam_login_access.c 
> >     lib/libpam/modules/pam_securetty pam_securetty.c 
> >     lib/libpam/modules/pam_unix pam_unix.c 
> >   Added files:
> >     lib/libpam/modules/pam_login_access pam_login_access.h 
> >   Log:
> >   WARNS=n fixes (and some stylistic issues).
> 
> You've introduced memory leaks and potential segfaults in pam_unix()
> (you added strdup()s in several places but you don't check the return
> value and don't free() them later).

Drat. I'll fix that.

> Other stuff:
> 
>  - pam_securetty should use _PATH_DEV instead of TTY_PREFIX

Yes.

>  - some long lines should be split (have to ask bde about that)

Just do it. Usual 4-space indent applies.

>  - commit included non-trivial changes to salt generation which should
>    have been mentioned in log message (others would say they should
>    have been committed separately, but I don't mind)

Dammit. I did not mean to commit that yet. I'll force a commit anyway
to mention it in the logs.

M
-- 
o       Mark Murray
\_      FreeBSD Services Limited
O.\_    Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message