From owner-cvs-src@FreeBSD.ORG Fri Feb 20 19:25:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6908216A4DD; Fri, 20 Feb 2004 19:25:51 -0800 (PST) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD86D43D39; Fri, 20 Feb 2004 19:25:50 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i1L3Pn5O011446; Sat, 21 Feb 2004 14:25:49 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i1L3Pj0I032046; Sat, 21 Feb 2004 14:25:46 +1100 Date: Sat, 21 Feb 2004 14:25:45 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Marcel Moolenaar In-Reply-To: <20040220195926.GA20936@ns1.xcllnt.net> Message-ID: <20040221141407.A7632@gamplex.bde.org> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <200402180839.09285.jhb@FreeBSD.org> <20040218174059.GC7878@ns1.xcllnt.net> <200402181414.01381.jhb@FreeBSD.org> <20040220191831.B4626@gamplex.bde.org> <20040220195926.GA20936@ns1.xcllnt.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@FreeBSD.org cc: John Baldwin cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Poul-Henning Kamp cc: Jun Kuriyama Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2004 03:25:51 -0000 On Fri, 20 Feb 2004, Marcel Moolenaar wrote: > On Fri, Feb 20, 2004 at 07:32:09PM +1100, Bruce Evans wrote: > > MPASS() has the same problems as line numbers in panic messages (except > > for the implementation bugs (misformatting of the output etc.)): verbose > > messages and breakage of simple regression tests. > > Note that however you look at it, failed assertions and panics are > expected to not happen. I hope at least that we're not designing > the kernel based on the frequent occurrence of these. In case they > do happen, I expect that they help in identifying the root cause. Yes, they shouldn't get in the way of normal things. > If a failed assertion or a panic breaks a simple regression test, it > means there's a bug and that it needs to be found and fixed. You're > not supposed to complain that the message printed by the assert or > panic logic messes up the testing. It doesn't mean that. E.g., the following sources produce different object files if panic() adds line numbers: %%% #include #include void foo(void) { panic(""); } %%% %%% #include #include void foo(void) { panic(""); } %%% so cleanups that should have no effect on the gnerated code mostly do affect the generated code. Bruce