From owner-svn-src-all@FreeBSD.ORG Fri Jun 11 01:46:35 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34B52106566B; Fri, 11 Jun 2010 01:46:35 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.freebsd.org (Postfix) with ESMTP id A0D478FC12; Fri, 11 Jun 2010 01:46:34 +0000 (UTC) Received: from ur.gsoft.com.au (Ur.gsoft.com.au [203.31.81.44]) (authenticated bits=0) by cain.gsoft.com.au (8.14.4/8.14.3) with ESMTP id o5B1kPQQ062423 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 11 Jun 2010 11:16:30 +0930 (CST) (envelope-from doconnor@gsoft.com.au) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: "Daniel O'Connor" In-Reply-To: <201006102034.o5AKYMXX058081@svn.freebsd.org> Date: Fri, 11 Jun 2010 11:16:24 +0930 Content-Transfer-Encoding: quoted-printable Message-Id: <3BE36947-BCB4-4A6D-9040-873CFD144F3B@gsoft.com.au> References: <201006102034.o5AKYMXX058081@svn.freebsd.org> To: Rui Paulo X-Mailer: Apple Mail (2.1078) X-Spam-Score: -2.51 () ALL_TRUSTED,BAYES_00,T_RP_MATCHES_RCVD X-Scanned-By: MIMEDefang 2.67 on 203.31.81.10 Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r209011 - stable/8/sys/dev/ath/ath_hal/ar5211 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2010 01:46:35 -0000 On 11/06/2010, at 6:04, Rui Paulo wrote: > Log: > MFC r208644: > Due to the way HALDEBUG() is defined, we need to add curly brackets > when using it as a sole if clause instruction. > While there, fix 'const static' typo. Why not fix HALDEBUG? ie wrap it in do { } while (0) Although that said when I looked at HALDEBUG on 8.0 it was defined as a = function so it is a non issue there. HAL_DEBUG is different but I can't actually find where that is defined. -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C