From owner-freebsd-geom@FreeBSD.ORG Tue Jul 27 09:03:48 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADE73106567B for ; Tue, 27 Jul 2010 09:03:48 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 3CCBF8FC08 for ; Tue, 27 Jul 2010 09:03:47 +0000 (UTC) Received: from critter.freebsd.dk (unknown [192.168.51.2]) by phk.freebsd.dk (Postfix) with ESMTP id E43E33F624; Tue, 27 Jul 2010 08:46:03 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.4/8.14.4) with ESMTP id o6R8k3PM024823; Tue, 27 Jul 2010 08:46:03 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Motin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 27 Jul 2010 10:58:20 +0300." <4C4E919C.2060009@FreeBSD.org> Date: Tue, 27 Jul 2010 08:46:03 +0000 Message-ID: <24822.1280220363@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: freebsd-geom@FreeBSD.org Subject: Re: Hyperactive g_event thread X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2010 09:03:48 -0000 In message <4C4E919C.2060009@FreeBSD.org>, Alexander Motin writes: >The only reason for doing it I >see in imperfect locking of g_run_events() loop and respective >tsleep()/wakeup(). So timeout there may be needed for collection >potentially lost wakeup() events. Back when GEOM was written, the kernels SMP facilites were rather rudimentary and in a few cases downright buggy, so workarounds like that timeout were employed. They can hopefully safely be removed now. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.