From owner-svn-src-head@freebsd.org  Thu Nov 19 03:56:24 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 814B4A31309;
 Thu, 19 Nov 2015 03:56:24 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 6C8DE1C39;
 Thu, 19 Nov 2015 03:56:24 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id 65A281824;
 Thu, 19 Nov 2015 03:56:24 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 1C42016E9D;
 Thu, 19 Nov 2015 03:56:24 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id QOqxrvag55qC; Thu, 19 Nov 2015 03:56:22 +0000 (UTC)
Subject: Re: svn commit: r288966 - head/share/mk
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com CB4E216E94
To: "Simon J. Gerraty" <sjg@juniper.net>
References: <201510070032.t970WYvU099368@repo.freebsd.org>
 <56146B4E.5040401@FreeBSD.org> <24053.1444240925@chaos>
 <56155FE0.7020809@FreeBSD.org> <564D29A0.6040000@FreeBSD.org>
 <15117.1447905199@chaos>
Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <564D4865.4050702@FreeBSD.org>
Date: Wed, 18 Nov 2015 19:56:21 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <15117.1447905199@chaos>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2015 03:56:24 -0000

On 11/18/15 7:53 PM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>> > As for the actual change in local.autodep.mk, I don't think it is needed
>> > or right since bsd.lib.mk and bsd.prog.mk already do exactly the same
>> > thing via ${OBJS}: ${SRCS:M*.h} if .depend is not yet generated. This
>> > does work in meta mode as I ran into a failure due to it before r291046
>> > (I had removed the libbfd/Makefile.depend.host for other testing). It's
>> > also hooked in far too late and orthogonally to the OBJS in the graph
>> > that need the headers.
> Forgive me; what is "it" in the last sentence?
> 
> It is never too late to add a dependency.
> It can easily be too late to add a value to a variable - to affect
> dependencies.

"It" is the header dependency. buildfiles is too late. This would need
to be on OBJS (which bsd.prog.mk/bsd.lib.mk already do, to ensure the
header is part of the object's dependency tree) or beforebuild. Putting
it on buildfiles is a separate part of the dependency tree than the
objects are in.

-- 
Regards,
Bryan Drewery