From nobody Sun Mar 10 09:43:14 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tsw2Q66P0z5Dj3l; Sun, 10 Mar 2024 09:43:26 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tsw2Q5cG6z4R3W; Sun, 10 Mar 2024 09:43:26 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710063806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VTDDH7E/eiWHqzRkojM7aBE1AL29uamS9LeUjtXayFs=; b=vaUp4ob8ytZQ2K773mSabqXBgQjSPdduuc8Cgp26chY9TEA8eTdv/ap/JNLfuuPsMqGF/s UAmrPzrkk4fwYq94ktFgiD/eHX3dJPiruo1mzdqmtYwYTk54ediS5UmV47biI3yoLD6dZA Y9/nnybkJ8aw6PIyWGnhHY10Y42heIstNwStOGK1Ew3kkA6xauOdJuxEF2yDnDk5wjlei5 NTICP6wAWxwjM/NMWP/Z1h36JSFt68Wd17OaJD076QuXVGCt9YHIEzxtYzAPlq1pJ+wqkF gSo9Jd8M5CUED7a9zFNgEkwiD0H5xiZ9hkBbP6rBWrKE0enkhWFv/TLhHLKDkQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710063806; a=rsa-sha256; cv=none; b=xzQ8nGZSU6ajs5M4UGUFplm2Ngzh6NUyd2yCI6NFoRQAAPRqFlIjGd1HrfkBuQvPDeK4re c5tvxr0BZh4sK7+BJbzhb4VTEfd3xB28zFSV0nRCE0I+YKYjE7voyr8NbnfKDM76V5TKAj W6AQnIPrlnri9kNN5rtG8Em0rEbkPD0lOvDXZakkSRfBbeSi32kX2X+Us+Y1Ugfb+zoma1 N76NrjjgbxaZ+oDbUTj8A4tTYqptnIKAoYu9M0oSer0GEmBrbP96sTq9vhTq5w5ju4HTnN Tf19xmvfDNoJqkZ0GOHZQuzyebmFJ5YUgu/lCSZvdxnMezK5lcsvryqIQCt+jA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710063806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VTDDH7E/eiWHqzRkojM7aBE1AL29uamS9LeUjtXayFs=; b=DUX2UCdvXelMUSnsdtofygYKADMPUH82qWFnhmy5/xjarIkFxacm9tY1ni62SAIF+Vsixq 49hnR4/UiaXCr24DZVkRo1ATbKCgSWglYKnXa2NP0pZYJRIEprg29uppJOfi6d5YiDcl1l DxCC+cosCnrbkYSWY5lPGlJ3F7TIFvgut0/Gyb8SnUXiZlrcr56La5/5CRbkrM3XpXdXGa Dqu94uVuj3JfdVHAEc5qiRXcWFxRZs+6dJYvKf3fHjpPMm+uqBndPILpvRck6s17jn1D4j M54IZVBoBS8cuJMNsS0o1r6eC2JReK5DgG7ezY1EhM1fZh8qYs7K/Ex5nsUpFw== Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Tsw2Q54G4zGVg; Sun, 10 Mar 2024 09:43:26 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6e0f43074edso2397402a34.1; Sun, 10 Mar 2024 01:43:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUDEIvOv+4fj3hQiZ3njLrA3INFAO5A1XN1PPQdgnJytP419qi37COSPBDZnWXTwKfkdnAWcSIG/QB9EW+nnIP5hx7qrnLpc15ovdQEC0npWo6qY95A9zPlM2KUWBxAvuPCJO5y/buc/ruYMTovyjwDAqmy3Ys= X-Gm-Message-State: AOJu0YxTKRyFQY9zOJWnsxMi+cq4iBEy/JwLsRzBZ1TS/wgZUMZMTTRf OJtcheNrpiurmqIGx5eGqhkOFD0UNmYAR4HVptlO39OAo74bWzbHvQC6l5pMwyW4vd2IJFAHBSH CNN0WJ6zcU4MY1QyUb7N6H3w03J8= X-Google-Smtp-Source: AGHT+IE8hoQMtUms3sScXuZojmGCqN/WSSZU8fKbMSvV3okIN6VX+CzTjKNCteVhNZ9pCMnPHxf787Cys9Wxy6z1xOo= X-Received: by 2002:a05:6359:504b:b0:17b:80e2:a105 with SMTP id om11-20020a056359504b00b0017b80e2a105mr2047273rwb.24.1710063805789; Sun, 10 Mar 2024 01:43:25 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403090831.4298VJo6024021@gitrepo.freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Sun, 10 Mar 2024 09:43:14 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 021fcd36af22 - main - games/coffeebreak: Move man pages to share/man To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello danfe! Good point. The problem here is that I can't use MANDIR in MAKE_ARGS because Makefile have $(DESTDIR) defined in MANDIR var. MANDIR =3D $(DESTDIR)$(PREFIX)/man Also, SED is needed anyway to fix hardcoded "/usr/local" to PREFIX. Any sugestions to simplify this? Thanks, Alexey Dokuchaev escreveu (domingo, 10/03/2024 =C3=A0(s= ) 09:16): > > On Sat, Mar 09, 2024 at 08:31:19AM +0000, Nuno Teixeira wrote: > > commit 021fcd36af22585a4bcf6e71ccb9a7d0f6ed204a > > > > games/coffeebreak: Move man pages to share/man > > ... > > + > > +post-patch: > > + ${REINPLACE_CMD} 's|/usr/local|${PREFIX}|g' ${WRKSRC}/Makefile > > > > .include > > ... > > +--- Makefile.orig 2024-03-09 06:57:33 UTC > > ++++ Makefile > > +@@ -27,7 +27,7 @@ BINDIR =3D $(DESTDIR)$(PREFIX)/bin > > + > > + PREFIX =3D /usr/local > > + BINDIR =3D $(DESTDIR)$(PREFIX)/bin > > +-MANDIR =3D $(DESTDIR)$(PREFIX)/man > > ++MANDIR =3D $(DESTDIR)$(PREFIX)/share/man > > We typically don't patch makefiles, esp. twice (sed+patch) when we have > MAKE_ARGS for that matter. Grepping "git log" output for MAKE_ARGS can > yield plenty of examples. > > ./danfe --=20 Nuno Teixeira FreeBSD Committer (ports)