From owner-svn-src-all@freebsd.org Tue Mar 12 22:22:50 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6012815408DC; Tue, 12 Mar 2019 22:22:50 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BFDB189002; Tue, 12 Mar 2019 22:22:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f170.google.com with SMTP id a17so3771210ljd.4; Tue, 12 Mar 2019 15:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oa9vDNcxWp4QBdEbSePz3TLdKoM4b8icq3laRXsNI3Y=; b=LWbPD0LN8tGT9sc6vZ4U3jlrtgduG2wETsgUUKDcZK9jPKfbXXmzNaTbOHOsmmkRI+ qcP44Y6H06xbPFyN0P6XZ1c9sBmWMBujh3/T8jag+iyFvTHM4Si9GC14tgT58Ifwpu8y anssf8fCygZYXQgBEcrgmXffzJ559VtnTxcTMQ2TI3z0qIFElCvbLsFaVaehoZJ+AMh1 bNDxPWsGjpeBmPzkvFK4rByrbo7k0ETESqKdWyxAZZ2LJu3bdcO1CwtA33PngBI9T7Kt ITTEtODrbZTmd2e7O/prufn7Rn22J2gBem8Mj0oODRpoDOcJVhibMwmwHat/S1ypjl3K X/bg== X-Gm-Message-State: APjAAAWMFXGMW759FRJZoGdOkUojmin8psZ4Sf9VunJHjNSWhr2inZpd cxxN3Y8AL8GlY5xzbPqKE5myXX4QhPgpYUW2N58r8w== X-Google-Smtp-Source: APXvYqynvnZ8eoKhXNUwVFBw9hamOBr+katx1RXvZm3MqucCkNEiIcNa4RefPmO8KbaAALxiBw4ZGtn5RIzfHKo4mTs= X-Received: by 2002:a2e:870c:: with SMTP id m12mr1836583lji.24.1552429367405; Tue, 12 Mar 2019 15:22:47 -0700 (PDT) MIME-Version: 1.0 References: <201705230929.v4N9T5g1028124@repo.freebsd.org> <20190312222035.GX2492@kib.kiev.ua> In-Reply-To: <20190312222035.GX2492@kib.kiev.ua> From: Alan Somers Date: Tue, 12 Mar 2019 16:22:35 -0600 Message-ID: Subject: Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi... To: Konstantin Belousov Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BFDB189002 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 22:22:50 -0000 On Tue, Mar 12, 2019 at 4:20 PM Konstantin Belousov wrote: > > On Tue, Mar 12, 2019 at 03:58:31PM -0600, Alan Somers wrote: > > On Tue, May 23, 2017 at 3:29 AM Konstantin Belousov wrote: > > > > > > Author: kib > > > Date: Tue May 23 09:29:05 2017 > > > New Revision: 318736 > > > URL: https://svnweb.freebsd.org/changeset/base/318736 > > > > > > Log: > > > Commit the 64-bit inode project. > > > > > > Extend the ino_t, dev_t, nlink_t types to 64-bit ints. Modify > > > struct dirent layout to add d_off, increase the size of d_fileno > > > to 64-bits, increase the size of d_namlen to 16-bits, and change > > > the required alignment. Increase struct statfs f_mntfromname[] and > > > f_mntonname[] array length MNAMELEN to 1024. > > > > > > ABI breakage is mitigated by providing compatibility using versioned > > > symbols, ingenious use of the existing padding in structures, and > > > by employing other tricks. Unfortunately, not everything can be > > > fixed, especially outside the base system. For instance, third-party > > > APIs which pass struct stat around are broken in backward and > > > forward incompatible ways. > > > > > > Kinfo sysctl MIBs ABI is changed in backward-compatible way, but > > > there is no general mechanism to handle other sysctl MIBS which > > > return structures where the layout has changed. It was considered > > > that the breakage is either in the management interfaces, where we > > > usually allow ABI slip, or is not important. > > > > > > Struct xvnode changed layout, no compat shims are provided. > > > > > > For struct xtty, dev_t tty device member was reduced to uint32_t. > > > It was decided that keeping ABI compat in this case is more useful > > > than reporting 64-bit dev_t, for the sake of pstat. > > > > > > Update note: strictly follow the instructions in UPDATING. Build > > > and install the new kernel with COMPAT_FREEBSD11 option enabled, > > > then reboot, and only then install new world. > > > > > > Credits: The 64-bit inode project, also known as ino64, started life > > > many years ago as a project by Gleb Kurtsou (gleb). Kirk McKusick > > > (mckusick) then picked up and updated the patch, and acted as a > > > flag-waver. Feedback, suggestions, and discussions were carried > > > by Ed Maste (emaste), John Baldwin (jhb), Jilles Tjoelker (jilles), > > > and Rick Macklem (rmacklem). Kris Moore (kris) performed an initial > > > ports investigation followed by an exp-run by Antoine Brodin (antoine). > > > Essential and all-embracing testing was done by Peter Holm (pho). > > > The heavy lifting of coordinating all these efforts and bringing the > > > project to completion were done by Konstantin Belousov (kib). > > > > > > Sponsored by: The FreeBSD Foundation (emaste, kib) > > > Differential revision: https://reviews.freebsd.org/D10439 > > > > What's the purpose of the new dirent.d_off field? I can't find any > > code that uses it. > It is supposed to help NFS server. They are supposed to provide directly the > cookies for nfs readdir call. But it is not required, and corresponding > code was not committed to FreeBSD fs/nfs yet. > > > I'm wondering if the fuse(4) module should set it > > in order to work properly over NFS, or something. > > No, it is not strictly required. OTOH, there is userspace implementation > of NFS server which seems to make use of it when available. This is why > r340431 was done. Would that be unfs3 or nfs-ganesha? I might add it to my list of stuff to test. -Alan