Date: Mon, 09 Nov 2009 22:11:25 +0100 (CET) From: Alexander Best <alexbestms@wwu.de> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: freebsd-hackers@FreeBSD.org, Giorgos Keramidas <keramida@freebsd.org> Subject: Re: [patch] burncd: honour for envar SPEED Message-ID: <permail-200911092111251e86ffa80000575d-a_best01@message-id.uni-muenster.de> In-Reply-To: <86aayvfmaa.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a MIME encoded multipart message.
--+permail-200911092111251e86ffa80000575d-a_best01+
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Dag-Erling Sm=F8rgrav schrieb am 2009-11-09:
> Alexander Best <alexbestms@wwu.de> writes:
> > + if ((env_speed =3D getenv("BURNCD_SPEED")) !=3D NULL) {
> > + if (strcasecmp("max", env_speed) =3D=3D 0)
> > + speed =3D CDR_MAX_SPEED;
> > + else
> > + speed =3D atoi(env_speed) * 177;
> > + if (speed <=3D 0)
> > + errx(EX_USAGE, "Invalid speed: %s",
> > env_speed);
> > + }
> > +
> > while ((ch =3D getopt(argc, argv, "def:Flmnpqs:tv")) !=3D -1) {
> > switch (ch) {
> > case 'd':
> You realize you're duplicating 6 lines of non-trivial code for no
> good
> reason?
> env_speed =3D getenv("BURNCD_SPEED");
> while ((ch =3D getopt(...)) !=3D -1) {
> switch (ch) {
> case 's':
> env_speed =3D optarg;
> break;
> ...
> }
> }
> if (env_speed !=3D NULL) {
> if (strcasecmp...) {
> ...
> }
> }
> DES
good point. is this one better?
alex
--+permail-200911092111251e86ffa80000575d-a_best01+
Content-Type: text/plain
Content-Transfer-Encoding: Base64
Content-Disposition: attachment; filename="burncdspeedpatch.txt"
SW5kZXg6IHVzci5zYmluL2J1cm5jZC9idXJuY2QuOAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1c3Iuc2Jpbi9i
dXJuY2QvYnVybmNkLjgJKHJldmlzaW9uIDE5OTA2NCkKKysrIHVzci5zYmluL2J1cm5jZC9idXJu
Y2QuOAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNyBAQAogLlwiCiAuXCIgJEZyZWVCU0Qk
CiAuXCIKLS5EZCBNYXkgMiwgMjAwNQorLkRkIE5vdiA5LCAyMDA5CiAuT3MKIC5EdCBCVVJOQ0Qg
OAogLlNoIE5BTUUKQEAgLTE1OCw3ICsxNTgsMTEgQEAKIC5TaCBFTlZJUk9OTUVOVAogVGhlIGZv
bGxvd2luZyBlbnZpcm9ubWVudCB2YXJpYWJsZXMgYWZmZWN0IHRoZSBleGVjdXRpb24gb2YKIC5O
bSA6Ci0uQmwgLXRhZyAtd2lkdGggIi5FdiBDRFJPTSIKKy5CbCAtdGFnIC13aWR0aCAiLkV2IEJV
Uk5DRF9TUEVFRCIKKy5JdCBFdiBCVVJOQ0RfU1BFRUQKK1RoZSB3cml0ZSBzcGVlZCB0byB1c2Ug
aWYgb25lIGlzIG5vdCBzcGVjaWZpZWQgd2l0aCB0aGUKKy5GbCBzCitmbGFnLgogLkl0IEV2IENE
Uk9NCiBUaGUgQ0QgZGV2aWNlIHRvIHVzZSBpZiBvbmUgaXMgbm90IHNwZWNpZmllZCB3aXRoIHRo
ZQogLkZsIGYKSW5kZXg6IHVzci5zYmluL2J1cm5jZC9idXJuY2QuYwo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1
c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMJKHJldmlzaW9uIDE5OTA2NCkKKysrIHVzci5zYmluL2J1
cm5jZC9idXJuY2QuYwkod29ya2luZyBjb3B5KQpAQCAtODAsMTEgKzgwLDEzIEBACiAJaW50IGRh
byA9IDAsIGVqZWN0ID0gMCwgZml4YXRlID0gMCwgbGlzdCA9IDAsIG11bHRpID0gMCwgcHJlZW1w
ID0gMDsKIAlpbnQgbm9nYXAgPSAwLCBzcGVlZCA9IDQgKiAxNzcsIHRlc3Rfd3JpdGUgPSAwLCBm
b3JjZSA9IDA7CiAJaW50IGJsb2NrX3NpemUgPSAwLCBibG9ja190eXBlID0gMCwgY2RvcGVuID0g
MCwgZHZkcncgPSAwOwotCWNvbnN0IGNoYXIgKmRldjsKKwljb25zdCBjaGFyICpkZXYsICplbnZf
c3BlZWQ7CiAKIAlpZiAoKGRldiA9IGdldGVudigiQ0RST00iKSkgPT0gTlVMTCkKIAkJZGV2ID0g
Ii9kZXYvYWNkMCI7CiAKKwllbnZfc3BlZWQgPSBnZXRlbnYoIkJVUk5DRF9TUEVFRCIpOworCiAJ
d2hpbGUgKChjaCA9IGdldG9wdChhcmdjLCBhcmd2LCAiZGVmOkZsbW5wcXM6dHYiKSkgIT0gLTEp
IHsKIAkJc3dpdGNoIChjaCkgewogCQljYXNlICdkJzoKQEAgLTEyNCwxMiArMTI2LDcgQEAKIAkJ
CWJyZWFrOwogCiAJCWNhc2UgJ3MnOgotCQkJaWYgKHN0cmNhc2VjbXAoIm1heCIsIG9wdGFyZykg
PT0gMCkKLQkJCQlzcGVlZCA9IENEUl9NQVhfU1BFRUQ7Ci0JCQllbHNlCi0JCQkJc3BlZWQgPSBh
dG9pKG9wdGFyZykgKiAxNzc7Ci0JCQlpZiAoc3BlZWQgPD0gMCkKLQkJCQllcnJ4KEVYX1VTQUdF
LCAiSW52YWxpZCBzcGVlZDogJXMiLCBvcHRhcmcpOworCQkJZW52X3NwZWVkID0gb3B0YXJnOwog
CQkJYnJlYWs7CiAKIAkJY2FzZSAndCc6CkBAIC0xNDcsNiArMTQ0LDEzIEBACiAJYXJnYyAtPSBv
cHRpbmQ7CiAJYXJndiArPSBvcHRpbmQ7CiAKKwlpZiAoc3RyY2FzZWNtcCgibWF4IiwgZW52X3Nw
ZWVkKSA9PSAwKQorCQkgc3BlZWQgPSBDRFJfTUFYX1NQRUVEOworCWVsc2UKKwkJc3BlZWQgPSBh
dG9pKGVudl9zcGVlZCkgKiAxNzc7CisJaWYgKHNwZWVkIDw9IDApCisJCWVycngoRVhfVVNBR0Us
ICJJbnZhbGlkIHNwZWVkOiAlcyIsIG9wdGFyZyk7CisJCQogCWlmIChhcmdjID09IDApCiAJCXVz
YWdlKCk7CiAK
--+permail-200911092111251e86ffa80000575d-a_best01+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-200911092111251e86ffa80000575d-a_best01>