From owner-svn-src-all@FreeBSD.ORG Tue Oct 28 15:31:17 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E745F1065879; Tue, 28 Oct 2008 15:31:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 68EF68FC1D; Tue, 28 Oct 2008 15:31:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id m9SFUCWp024647; Tue, 28 Oct 2008 11:31:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Bjoern A. Zeeb" Date: Tue, 28 Oct 2008 11:11:48 -0400 User-Agent: KMail/1.9.7 References: <200810271515.m9RFF86d042970@svn.freebsd.org> <200810271418.41291.jhb@freebsd.org> <20081028065010.A2978@maildrop.int.zabbadoz.net> In-Reply-To: <20081028065010.A2978@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810281111.48833.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 28 Oct 2008 11:31:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8526/Tue Oct 28 09:21:35 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184341 - head/usr.sbin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2008 15:31:18 -0000 On Tuesday 28 October 2008 02:56:23 am Bjoern A. Zeeb wrote: > On Mon, 27 Oct 2008, John Baldwin wrote: > > > On Monday 27 October 2008 11:15:08 am Bjoern A. Zeeb wrote: > >> Author: bz > >> Date: Mon Oct 27 15:15:08 2008 > >> New Revision: 184341 > >> URL: http://svn.freebsd.org/changeset/base/184341 > >> > >> Log: > >> We do not have a libkse anymore and Mk/bsd.* does not know > >> about LIBKSE anymore, so s,MK_LIBKSE,MK_LIBPTHREAD,. > > > > Shouldn't you just remove it instead? These two options are now basically > > identical. (We probably should rename libthr to libpthread at some point.) > > tools/build/options/WITHOUT_LIBPTHREAD still talks about kse and thus > does src.conf(5). That should be updated. > I wouldn't object to removing one of the options but according to the > src.conf my bet would be LIBTHR and not LIBPTHREAD. > So updating the documentation might be a good initial step as well. Note that MK_LIBTHR == "NO" implies MK_LIBPTHREAD == "NO" (see bsd.own.mk), but not the other way around. So for now the correct knob to check in Makefiles is MK_LIBTHR (since it gets set to NO in both the WITHOUT_LIBTHR and WITHOUT_LIBPTHREAD cases, but MK_LIBPTHREAD isn't set to NO if you just do WITHOUT_LIBTHR). > I have to admit that I lost track about our threading libs in > different branches at one time; how many are left in head - 1 or 2? > Is only libthr left and we build it as libthr and add symlinks for > libpthread? Yes. -- John Baldwin