From owner-p4-projects@FreeBSD.ORG Sat Jul 31 20:33:09 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 782B11065675; Sat, 31 Jul 2010 20:33:09 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24604106564A; Sat, 31 Jul 2010 20:33:09 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id CF6CE8FC12; Sat, 31 Jul 2010 20:33:08 +0000 (UTC) Received: by iwn35 with SMTP id 35so3376739iwn.13 for ; Sat, 31 Jul 2010 13:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=07xmp13czXDSg23oMy0caPfuNI/auN93Xhu02RDQEwU=; b=n63tEfiBVhRzgy2wHEIJoqXPPa7fnhwt8WVN5rB6EiNqqO5SsRbP21vZIYT6v/zScv OlZUFnaAez5ia+Mm6Soygi2XvdtHhYF+BLGfWv542BrEG2e6V559V93lOXZ55GGdQSjW sspoOiG05UqEwjqPNMBkP0b3R7/1D9uateJEg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xNgg/u8hFpPSTpJlnTCgMtT3qEduTjBPprraIy3ggWGrsSzHt+0+lzEAQpu/J+uQ2V VktNK5pOECTrjbRXF5tAJkHcbhFRaTIMy4Rox8wanEkkHF+EeZXDruWw7+gLaDTLm8CX SxbhOfgnEmiaP7O2vhdlKZsni8YvPB5P6shQk= MIME-Version: 1.0 Received: by 10.231.39.201 with SMTP id h9mr4042049ibe.118.1280608385065; Sat, 31 Jul 2010 13:33:05 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.231.169.18 with HTTP; Sat, 31 Jul 2010 13:33:04 -0700 (PDT) In-Reply-To: <201007292123.o6TLN3Td039516@repoman.freebsd.org> References: <201007292123.o6TLN3Td039516@repoman.freebsd.org> Date: Sat, 31 Jul 2010 13:33:04 -0700 X-Google-Sender-Auth: Zw_OAtZ60wRYbK3MbdJBC7l6NHk Message-ID: From: Garrett Cooper To: Julien Laffaye Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 181582 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jul 2010 20:33:09 -0000 On Thu, Jul 29, 2010 at 2:23 PM, Julien Laffaye wrot= e: > http://p4web.freebsd.org/@@181582?ac=3D10 > > Change 181582 by jlaffaye@jlaffaye-chulak on 2010/07/29 21:23:01 > > =A0 =A0 =A0 =A0- Rework the fetch_archive() function to return a file des= criptor of the > =A0 =A0 =A0 =A0downloaded archive. > =A0 =A0 =A0 =A0Reading on-the-fly doesn't work if we fetch dependencies: = the remote > =A0 =A0 =A0 =A0server close the connection because we are inactive (in fa= ct we are > =A0 =A0 =A0 =A0busy downloading the dependency). Reading on-the-fly could= work if we > =A0 =A0 =A0 =A0knew the dependencies, in the proper order, of the package= before > =A0 =A0 =A0 =A0downloading it (thus, download and install the dependencie= s first). > =A0 =A0 =A0 =A0- While I'm here, print the progress (percentage) of the d= owload. > ... > + =A0 =A0 =A0 if (archive_read_open_fd(a, fd, 10240) !=3D ARCHIVE_OK) { > + =A0 =A0 =A0 =A0 =A0 warnx("archive_read_open_fd(): %s", archive_error_s= tring(a)); > + =A0 =A0 =A0 =A0 =A0 retcode =3D 1; > + =A0 =A0 =A0 =A0 =A0 goto cleanup; Overall change looks good, but why 10240 :)? -Garrett