From owner-svn-src-head@FreeBSD.ORG Wed Jan 7 17:44:39 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 42212741; Wed, 7 Jan 2015 17:44:39 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id ED3CE1AFE; Wed, 7 Jan 2015 17:44:38 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t07HiVT2042302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 7 Jan 2015 09:44:31 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t07HiVb7042301; Wed, 7 Jan 2015 09:44:31 -0800 (PST) (envelope-from jmg) Date: Wed, 7 Jan 2015 09:44:31 -0800 From: John-Mark Gurney To: Robert Watson Subject: Re: svn commit: r276750 - in head: share/man/man9 sys/contrib/ipfilter/netinet sys/dev/an sys/dev/bge sys/dev/ce sys/dev/cm sys/dev/cp sys/dev/cs sys/dev/ctau sys/dev/ed sys/dev/ex sys/dev/fe sys/dev/h... Message-ID: <20150107174430.GQ1949@funkthat.com> References: <201501061259.t06CxcTc096488@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201501061259.t06CxcTc096488@svn.freebsd.org> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Wed, 07 Jan 2015 09:44:31 -0800 (PST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2015 17:44:39 -0000 Robert Watson wrote this message on Tue, Jan 06, 2015 at 12:59 +0000: > Author: rwatson > Date: Tue Jan 6 12:59:37 2015 > New Revision: 276750 > URL: https://svnweb.freebsd.org/changeset/base/276750 > > Log: > In order to reduce use of M_EXT outside of the mbuf allocator and > socket-buffer implementations, introduce a return value for MCLGET() > (and m_cljget() that underlies it) to allow the caller to avoid testing > M_EXT itself. Update all callers to use the return value. > > With this change, very few network device drivers remain aware of > M_EXT; the primary exceptions lie in mbuf-chain pretty printers for > debugging, and in a few cases, custom mbuf and cluster allocation > implementations. > > NB: This is a difficult-to-test change as it touches many drivers for > which I don't have physical devices. Instead we've gone for intensive > review, but further post-commit review would definitely be appreciated > to spot errors where changes could not easily be made mechanically, > but were largely mechanical in nature. Shouldn't this come w/ a FreeBSD version bump for drivers to use? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."