From owner-freebsd-bugs@FreeBSD.ORG Wed Nov 28 02:20:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF07E16A41B for ; Wed, 28 Nov 2007 02:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B304513C44B for ; Wed, 28 Nov 2007 02:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lAS2K1oT044441 for ; Wed, 28 Nov 2007 02:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lAS2K1hw044440; Wed, 28 Nov 2007 02:20:01 GMT (envelope-from gnats) Resent-Date: Wed, 28 Nov 2007 02:20:01 GMT Resent-Message-Id: <200711280220.lAS2K1hw044440@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Weongyo Jeong Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE15E16A41B for ; Wed, 28 Nov 2007 02:18:41 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A177013C45A for ; Wed, 28 Nov 2007 02:18:41 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lAS2IYTY094296 for ; Wed, 28 Nov 2007 02:18:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id lAS2IY5W094295; Wed, 28 Nov 2007 02:18:34 GMT (envelope-from nobody) Message-Id: <200711280218.lAS2IY5W094295@www.freebsd.org> Date: Wed, 28 Nov 2007 02:18:34 GMT From: Weongyo Jeong To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/118297: ndiscvt(8): sort a output format. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2007 02:20:01 -0000 >Number: 118297 >Category: bin >Synopsis: ndiscvt(8): sort a output format. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 28 02:20:01 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Weongyo Jeong >Release: FreeBSD 7.0 CURRENT >Organization: CDNetworks >Environment: FreeBSD freebsd.weongyo.org 7.0-CURRENT FreeBSD 7.0-CURRENT #3: Sun Jun 24 21:47:30 KST 2007 weongyo@bsd.dev1.cdnetworks.co.kr:/usr/obj/usr/src/sys/GENERIC i386 You have mail in /var/mail/weongyo >Description: the output automatically generated by ndiscvt(8) is not easy to read. This fix sorts output formats. >How-To-Repeat: $ ndis -i -s -o tmp.h >Fix: Index: inf.c =================================================================== RCS file: /data/cvs/src/usr.sbin/ndiscvt/inf.c,v retrieving revision 1.16 diff -u -r1.16 inf.c --- inf.c 15 May 2005 19:46:14 -0000 1.16 +++ inf.c 28 Nov 2007 02:11:00 -0000 @@ -451,8 +451,8 @@ if (reg->section == sec) { if (reg->subkey == NULL) { fprintf(ofp, "\n\t{ \"%s\",", reg->key); - fprintf(ofp,"\n\t\"%s \",", reg->key); - fprintf(ofp, "\n\t{ \"%s\" }, %d },", + fprintf(ofp,"\n\t \"%s \",", reg->key); + fprintf(ofp, "\n\t { \"%s\" }, %d },", reg->value == NULL ? "" : stringcvt(reg->value), devidx); } else if (strncasecmp(reg->subkey, @@ -537,8 +537,8 @@ continue; if (reg->key == NULL || strcasecmp(reg->key, "Default")) continue; - fprintf(ofp, "\n\t{ \"%s\" }, %d },", reg->value == NULL ? "" : - stringcvt(reg->value), devidx); + fprintf(ofp, "\n\t { \"%s\" }, %d },", + reg->value == NULL ? "" : stringcvt(reg->value), devidx); break; } return; @@ -555,7 +555,7 @@ continue; if (reg->key == NULL || strcasecmp(reg->key, "ParamDesc")) continue; - fprintf(ofp, "\n\t\"%s", stringcvt(r->value)); + fprintf(ofp, "\n\t \"%s", stringcvt(r->value)); break; } return; >Release-Note: >Audit-Trail: >Unformatted: