From nobody Fri Jul 29 18:47:13 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lvc2B2hk5z4Y1fV; Fri, 29 Jul 2022 18:47:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lvc296DFCz3nhS; Fri, 29 Jul 2022 18:47:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wPu1R/NLrdZGGpOHlKZbujstTzxiQqTslIR8lwd1dZE=; b=Pi84vHwPoeLKtAegW+jFjf0AKTpkomnSiqthSQFz/ziXWDusmrmOuv5IsVLhmbodmtEUc1 ZyRhL5tyJ+4a8VbBl6V8DCKGVQeABQMAt6XrnvwynYQ2xedUpGHeXNWp02m1WDneMl1tBX aMU7UGrmbyc7453h6hJlvWu2SKw9a/xmgT/BhB7mSIWLyiurZDaOyJntn23aQqVwny5VU3 rv3kJvzQzWXwQ+gHyZSQWHyWT1Lx+88VeYLUe6PiC8TXlqypysQDQI7hq6p754Iucw5Ac/ 6L+2YMhmKTUFA8qLo0DgNDyqSRhojQb9tC+Ulhu8+Uv9anIEjz4fxQqWeYUEwQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lvc295Kw6zm44; Fri, 29 Jul 2022 18:47:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26TIlDcA023812; Fri, 29 Jul 2022 18:47:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26TIlDWP023811; Fri, 29 Jul 2022 18:47:13 GMT (envelope-from git) Date: Fri, 29 Jul 2022 18:47:13 GMT Message-Id: <202207291847.26TIlDWP023811@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: f2773b998c7d - stable/13 - Adjust function definitions in if_pfsync.c to avoid clang 15 warnings List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f2773b998c7d18a9f014065352d9b2ccb706f223 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wPu1R/NLrdZGGpOHlKZbujstTzxiQqTslIR8lwd1dZE=; b=uvwC8l3ZOnL+QoyzFu+u3JhCWb35cudUBYJgPLHicES2BP7J3gL+TodDS38stgdpOCgQSu PdyNthzfJ9A48L3WDgx6GnVJoMXLmR9o9V/aBPFK1qnkvr4u0LWP8lUcTOPiAQvxPyPD/v TetNchh2dDCZ6AkMwKqvC59lBD/6hJfBJ3SeUqJ05BDfP8Ory66C2ekmTUzbOi6EQACV2H xjy5u4bW9rKkz648+YCBPUjV9NOHCytjDwIrMVxlhhP5vHX1Sqwu0/416T1xXIRyjVsxlt uDbl+Hdb9FY+DEgb7GeGl0FwQMg8UolzSjHxuJC0oC/zfSUG7zex2WEDWbf+Mg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659120433; a=rsa-sha256; cv=none; b=g8VYl93qs0r2K+TO13hcDIOeIpR368wFUPo5KKrHYTZdGrJouA6ZA4biQAR1rrd571SQc8 7q8akN2y426aJOv0S1PSwjNsv3kxLze8amjx/lOVrJBUMuWeNlS/b6pPU0fSSPejcLwteW m7maNEjyK4GCsXbLU0ayHgQ2eATr9euVOC3PTJXAMb7pRTkOfsqKIEzXahnPoKpW3iXekB 44ioMW4y13a3CQlUMHGHoljtPFxFEUrqz98yqFjnDQee70N32wNh7lxud7zRZw/GU6tgXt /1jNH8z641uy+8JS177qnRxUrgthkxumqWiwIaiztUKk9ge156jIS/x2ZFUyUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=f2773b998c7d18a9f014065352d9b2ccb706f223 commit f2773b998c7d18a9f014065352d9b2ccb706f223 Author: Dimitry Andric AuthorDate: 2022-07-25 18:53:32 +0000 Commit: Dimitry Andric CommitDate: 2022-07-29 18:28:08 +0000 Adjust function definitions in if_pfsync.c to avoid clang 15 warnings With clang 15, the following -Werror warnings are produced: sys/netpfil/pf/if_pfsync.c:2439:21: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_pointers_init() ^ void sys/netpfil/pf/if_pfsync.c:2453:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_pointers_uninit() ^ void sys/netpfil/pf/if_pfsync.c:2503:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_init() ^ void sys/netpfil/pf/if_pfsync.c:2524:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_uninit() ^ void This is because pfsync_pointers_init(), pfsync_pointers_uninit(), pfsync_init(), and pfsync_uninit() are declared with (void) argument lists, but defined with empty argument lists. Make the definitions match the declarations. MFC after: 3 days (cherry picked from commit 766f3c8032a95f344823bea70bb7f794f9939d33) --- sys/netpfil/pf/if_pfsync.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 998f8a4f5521..e22e0d35f182 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2436,7 +2436,7 @@ static struct protosw in_pfsync_protosw = { #endif static void -pfsync_pointers_init() +pfsync_pointers_init(void) { PF_RULES_WLOCK(); @@ -2450,7 +2450,7 @@ pfsync_pointers_init() } static void -pfsync_pointers_uninit() +pfsync_pointers_uninit(void) { PF_RULES_WLOCK(); @@ -2500,7 +2500,7 @@ VNET_SYSUNINIT(vnet_pfsync_uninit, SI_SUB_PROTO_FIREWALL, SI_ORDER_FOURTH, vnet_pfsync_uninit, NULL); static int -pfsync_init() +pfsync_init(void) { #ifdef INET int error; @@ -2521,7 +2521,7 @@ pfsync_init() } static void -pfsync_uninit() +pfsync_uninit(void) { pfsync_detach_ifnet_ptr = NULL;