Date: Wed, 9 Aug 2017 09:13:03 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joseph Mingrone <jrm@freebsd.org> Subject: Re: svn commit: r447474 - head/www/rubygem-goldfinger Message-ID: <9a9ec899-701a-0d7c-c679-e2f7a977e47b@FreeBSD.org> In-Reply-To: <CAMHz58ShY8c=HWoxk0yN_PgfuLq7TaNsEhoVVw_C8qAkOD5WcA@mail.gmail.com> References: <201708061653.v76Gr9O9008539@repo.freebsd.org> <939bd115-95a7-f0dc-f018-b276488a091c@FreeBSD.org> <CAMHz58ShY8c=HWoxk0yN_PgfuLq7TaNsEhoVVw_C8qAkOD5WcA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso Content-Type: multipart/mixed; boundary="RuugP1cTclnPW8ap8ia1JtSGtXBKVDn1n"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joseph Mingrone <jrm@freebsd.org> Message-ID: <9a9ec899-701a-0d7c-c679-e2f7a977e47b@FreeBSD.org> Subject: Re: svn commit: r447474 - head/www/rubygem-goldfinger References: <201708061653.v76Gr9O9008539@repo.freebsd.org> <939bd115-95a7-f0dc-f018-b276488a091c@FreeBSD.org> <CAMHz58ShY8c=HWoxk0yN_PgfuLq7TaNsEhoVVw_C8qAkOD5WcA@mail.gmail.com> In-Reply-To: <CAMHz58ShY8c=HWoxk0yN_PgfuLq7TaNsEhoVVw_C8qAkOD5WcA@mail.gmail.com> --RuugP1cTclnPW8ap8ia1JtSGtXBKVDn1n Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 08/08/2017 =C3=A0 20:57, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > On Mon, Aug 7, 2017 at 4:53 AM, Mathieu Arnold <mat@freebsd.org > <mailto:mat@freebsd.org>> wrote: > > Hi, > > Le 06/08/2017 =C3=A0 18:53, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > Author: sunpoet > > Date: Sun Aug 6 16:53:09 2017 > > New Revision: 447474 > > URL: https://svnweb.freebsd.org/changeset/ports/447474 > <https://svnweb.freebsd.org/changeset/ports/447474>; > > > > Log: > > Use PORTVERSION > > Please revert. DISTVERSION is the preferred way of setting upstream= 's > version. > > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-nami= ng.html#makefile-versions > <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-nam= ing.html#makefile-versions> > > > Hi mat, > > Here's my reason of this change. (jrm@ is cc'd). > The majority of the ports tree (and almost all rubygem ports) use > PORTVERSION. [1] > It's my understanding that we use PORTVERSION in most cases. Yes, it is because it took me a while to document that we should all be using DISTVERSION and almost never PORTVERSION. > When upstream use versions like 1_2_3, 4.5-alpha6 or so, we use > DISTVERSION instead. > > Before I revert it, could you make it clear when to use PORTVERSION > and DISTVERSION? It is explained in the porter's handbook, always use DISTVERSION except when there is no version in the distribution file, or when DISTVERSION gives an incorrect PORTVERSION. --=20 Mathieu Arnold --RuugP1cTclnPW8ap8ia1JtSGtXBKVDn1n-- --e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZirYCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IlBcP/0EDCMbeAap0zw2SdJCJIMpD 0NP7qordDz9d6FOFjCg8svEp3gbTJXawr8PpFQ1pkL2/ZtLI/RAMSK5d35UWjO2V +Mj6xkB8rg8w3K5JTTDM/k4gypujMlnQUVwC9A05DBNMB+678nlfQd2HyWTY/j3g TPV8ONlgeDvyzofxwAVSLDtQBHIT3sWJrOw93w7VbzX978gO0vgpQrEZd352NQad gGdZuvab7H9MKAyz8zlJ3FmyrYDILlcP6FEmjLuYl+zPcnwT0cF7la4Z4A7TW0Tx HzPozcXlL9dB6zDsrd+0asqJelU6Zh6WBLI0hPM5O83UAWquRwa68gee1KiQdInN VSyRkRdOjhBDVPNvc5MEMtUaLnMAOkCFvYHnNk+h49PB89kR2+oH2yrVElOg/Amc +J3uSjfQQDl2+xKGLgti3PeQM9yoNgNQ1GmR4p+4AwlQbj5KjdFMQuMQRcFRJdy6 G6Rpv1ynNHGh7+Pk3Kh0buMdTz/tMrNaBOb3VeS4Id5oNwQWOhs++XJfesSFFz1z TavQk/8xrFn+e5EP01Qcm++AwZSOloTl/0tUt4Mwr1h03HXE1S+ExHBQmIyQYN/6 XHln7cxjMuN+zQQxVQ3DPAH2fT4NlmeQ9ij7VuVf3cGU13FnV50Wb+xYYxol4YbX Y9PnlXY8+9M9MG1eSv87 =U5Lh -----END PGP SIGNATURE----- --e9dnmQK44dFrcrjlnwNETUIMVHfUPOFso--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9a9ec899-701a-0d7c-c679-e2f7a977e47b>