Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jun 2016 00:39:48 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r302094 - in head/sys: compat/freebsd32 kern
Message-ID:  <20160623003948.GB41630@spindle.one-eyed-alien.net>
In-Reply-To: <5096414.4TN0ypqLNM@ralph.baldwin.cx>
References:  <201606222115.u5MLFxBD093628@repo.freebsd.org> <5096414.4TN0ypqLNM@ralph.baldwin.cx>

next in thread | previous in thread | raw e-mail | index | archive | help

--5/uDoXvLw7AC5HRs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 22, 2016 at 05:09:34PM -0700, John Baldwin wrote:
> On Wednesday, June 22, 2016 09:15:59 PM Brooks Davis wrote:
> > Author: brooks
> > Date: Wed Jun 22 21:15:59 2016
> > New Revision: 302094
> > URL: https://svnweb.freebsd.org/changeset/base/302094
> >=20
> > Log:
> >   Mark the pipe() system call as COMPAT10.
> >  =20
> >   As of r302092 libc uses pipe2() with a zero flags value instead of pi=
pe().
> >  =20
> >   Commit with regenerated files and implementation to follow.
>=20
> This breaks the build on at least i386 because other ABIs depend on being
> able to call sys_pipe directly.  You should at least add COMPAT_FREEBSD10
> to GENERIC on architectures that shipped a 10.x release.  That will fix t=
he
> build breakage on i386, but it's also the policy we follow for all the ot=
her
> compat knobs.

It was actually that sys_pipe() was renamed by the COMPAT10 tag.  I've
copied the implementation to a svr4_pipe().

-- Brooks

--5/uDoXvLw7AC5HRs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXay/TAAoJEKzQXbSebgfAUwkIAI+9MNKDIAiT4QUcT+7yGNMb
wBMrSkCbjaWjxUc5DVUjjL3uPMtx+dfFIAW8JR7KSpQytqfI0rKDVcHJbDNRrivx
Np/X+cJbmNXUJUKltgS+31XotNR6nmA0UoARslVPTBklF6+3BfjJ9pSGOGzYEuyc
vQT/mSMX8NK3TUhDqKeXGtPWvxA0yjMdDflUnlnEm0zXQPlggpnG6j3BBkabSdLy
+AJIoYk5aNj2SdtH+3noH5tP2YF4oB2m6hwn6OrIVC43jey0+VvalalMHhkaGIPK
u4Qev1/r8f4V3/2yzNwBvj3TXayKfXc35Q3mn6Duhr94LiPx1GuxUkcgdtbwcYg=
=SHFd
-----END PGP SIGNATURE-----

--5/uDoXvLw7AC5HRs--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160623003948.GB41630>