From owner-freebsd-bugs Sat Sep 7 15:25:40 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E17537B400; Sat, 7 Sep 2002 15:25:37 -0700 (PDT) Received: from smtp3.vol.cz (smtp3.vol.cz [195.250.128.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB9A843E6A; Sat, 7 Sep 2002 15:25:35 -0700 (PDT) (envelope-from dan@obluda.cz) Received: from obluda.cz (xkulesh.vol.cz [195.250.154.106]) by smtp3.vol.cz (8.12.5/8.12.5) with ESMTP id g87MPXnY047118; Sun, 8 Sep 2002 00:25:34 +0200 (CEST) (envelope-from dan@obluda.cz) Message-ID: <3D7A7CD7.4020708@obluda.cz> Date: Sun, 08 Sep 2002 00:25:27 +0200 From: Dan Lukes User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826 X-Accept-Language: cs, sk, en MIME-Version: 1.0 To: bmah@FreeBSD.org Cc: freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/42384: MDXFileChunk may return 0 instead of hash References: <200209071611.g87GBolU030973@freefall.freebsd.org> <3D7A5400.1010002@obluda.cz> <200209071948.g87JmI5v022524@intruder.bmah.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Bruce A. Mah wrote: >> With full respect to fact you are commiter, so final decision is your >>suverenity - can you think about revoking your's straightforward fix a >>commiting my (more performance friendly) one ? > Initializing this variable once per invocation of this function is going > to be insignificant compared to the time that it takes to run an MD5 > computation. Yes, the diference is few CPU cycles only, but why we waste it when saving it has NO negative consequences ? Well, you decided, i respect it. Howgh. Dan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message