Date: Wed, 21 Jul 2010 06:50:48 +1000 From: Peter Jeremy <peterjeremy@acm.org> To: Jeremy Chadwick <freebsd@jdc.parodius.com> Cc: freebsd-fs@freebsd.org Subject: Re: panic: handle_written_inodeblock: bad size Message-ID: <20100720205048.GA33373@server.vk2pj.dyndns.org> In-Reply-To: <20100720175709.GA52321@icarus.home.lan> References: <20100720134931.GA41352@icarus.home.lan> <201007201544.o6KFipaV084986@chez.mckusick.com> <20100720175709.GA52321@icarus.home.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2010-Jul-20 10:57:09 -0700, Jeremy Chadwick <freebsd@jdc.parodius.com> w=
rote:
>On Tue, Jul 20, 2010 at 08:44:51AM -0700, Kirk McKusick wrote:
>> So, it is almost always possible to make your way to fs_fsmnt.
>> Since soft updates only runs on mounted filesystems, you will never
>> have a case where the fs_fsmnt has not been filled in for you.
>
>Oh, cool. I was taking the paranoid approach ("does this really
>point to something that's valid? What if..."). :-)
In the case of panic messages, you probably should err on the side of
paranoia. By definition, getting to the point where you need to call
panic(9) means something unexpected has happened and it's probably not
being excessively paranoid to explicitly check each pointer before
de-referencing it.
--=20
Peter Jeremy
--OXfL5xGRrasGEqWY
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (FreeBSD)
iEYEARECAAYFAkxGDCgACgkQ/opHv/APuIeb1wCfTrwsIlBuw8iNfpKDxvcywODK
w7kAnRto1Ve3t1z8UyMgmEVZLNo17DMj
=1llG
-----END PGP SIGNATURE-----
--OXfL5xGRrasGEqWY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100720205048.GA33373>