From owner-freebsd-hackers@FreeBSD.ORG  Wed Jan 28 10:16:37 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7CBF1106564A
	for <hackers@freebsd.org>; Wed, 28 Jan 2009 10:16:37 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.freebsd.org (Postfix) with ESMTP id CA4838FC14
	for <hackers@freebsd.org>; Wed, 28 Jan 2009 10:16:36 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from kobe.laptop (adsl21-232.kln.forthnet.gr [77.49.148.232])
	(authenticated bits=128)
	by igloo.linux.gr (8.14.3/8.14.3/Debian-5) with ESMTP id n0SA2N5P011121
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Wed, 28 Jan 2009 12:02:28 +0200
Received: from kobe.laptop (kobe.laptop [127.0.0.1])
	by kobe.laptop (8.14.3/8.14.3) with ESMTP id n0SA2Mj3007935;
	Wed, 28 Jan 2009 12:02:22 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)
	by kobe.laptop (8.14.3/8.14.3/Submit) id n0SA2MCZ007934;
	Wed, 28 Jan 2009 12:02:22 +0200 (EET)
	(envelope-from keramida@freebsd.org)
From: Giorgos Keramidas <keramida@freebsd.org>
To: "M. Warner Losh" <imp@bsdimp.com>
References: <20090128.020950.-1962670362.imp@bsdimp.com>
Date: Wed, 28 Jan 2009 12:02:21 +0200
In-Reply-To: <20090128.020950.-1962670362.imp@bsdimp.com> (M. Warner Losh's
	message of "Wed, 28 Jan 2009 02:09:50 -0700 (MST)")
Message-ID: <87k58f7npu.fsf@kobe.laptop>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-MailScanner-ID: n0SA2N5P011121
X-Hellug-MailScanner: Found to be clean
X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
	score=-4.462, required 5, autolearn=not spam, ALL_TRUSTED -1.80,
	AWL -0.06, BAYES_00 -2.60)
X-Hellug-MailScanner-From: keramida@freebsd.org
X-Spam-Status: No
Cc: hackers@freebsd.org
Subject: Re: Code review request: cdcontrol status label additon
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2009 10:16:37 -0000

On Wed, 28 Jan 2009 02:09:50 -0700 (MST), "M. Warner Losh" <imp@bsdimp.com> wrote:
> Please find enclosed patches to enable printing of the ISO-9660 Volume
> label, if present, for a CD.  I've connected this to the 'status
> label' command.  Please comment.

The style looks ok, but this didn't work for a Fedora Core 10 disk I
have around.  glabel on the other hand detected the label fine:

  [ /var/log/messages ]
  Jan 28 11:59:00 kobe kernel: GEOM_LABEL: Label for provider acd0t01 is iso9660/F10-i686-Live.

Running `status label' on the same disk didn't find one:

  # ./cdcontrol status label
  No ISO 9660 label found
  # ./cdcontrol -f /dev/acd0t01 status label
  No ISO 9660 label found

Maybe it would be better to hook into glabel (when available) or use a
userland copy of the same code?