From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 14 07:54:56 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3C2ED57; Thu, 14 Nov 2013 07:54:56 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AA0A42473; Thu, 14 Nov 2013 07:54:56 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa04.fnfis.com (8.14.5/8.14.5) with ESMTP id rAE7st2I013177 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 14 Nov 2013 01:54:55 -0600 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.152]) by LTCFISWMSGHT06.FNFIS.com ([10.132.206.17]) with mapi id 14.03.0158.001; Thu, 14 Nov 2013 01:54:54 -0600 From: "Teske, Devin" To: Alfred Perlstein Subject: Re: Loader forth changes for customization Thread-Topic: Loader forth changes for customization Thread-Index: AQHO4EjnMi0GIoZQO0eCkJ5RnRP0Cw== Date: Thu, 14 Nov 2013 07:54:54 +0000 Message-ID: References: <5282E56F.4020307@freebsd.org> <52832003.8080406@freebsd.org> <09673101-DB54-4D25-9989-8C80D06E266B@fisglobal.com> <5283933E.30603@freebsd.org> In-Reply-To: <5283933E.30603@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.120] Content-Type: multipart/mixed; boundary="_002_BCC78B2C66F042C3AD53018637B2C433fisglobalcom_" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.14, 0.0.0000 definitions=2013-11-13_06:2013-11-13,2013-11-13,1970-01-01 signatures=0 Cc: FreeBSD Hackers , Devin Teske , "Teske, Devin" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: Devin Teske List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 07:54:57 -0000 --_002_BCC78B2C66F042C3AD53018637B2C433fisglobalcom_ Content-ID: <0FDD9F0F0DEAAA4BBFDFBC6EF71C7C67@fisglobal.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" On Nov 13, 2013, at 6:57 AM, Alfred Perlstein wrote: >=20 > On 11/13/13, 12:18 AM, Teske, Devin wrote: >> On Nov 12, 2013, at 10:45 PM, Alfred Perlstein wrote: >>=20 >>> I added some hooks for menu.rc as well, you can see it via the github u= rls below. >>>=20 >>> I've attached a sample menu.rc.local that provides additional menus. >>>=20 >>> -Alfred >>>=20 >>> On 11/12/13, 6:35 PM, Alfred Perlstein wrote: >>>> Hey folks, >>>>=20 >>>> I added some forth using Devin's help to make it easier to customize t= he FreeBSD boot loader graphics. >>>>=20 >>>> Diffs are here: >>>> https://github.com/alfredperlstein/freebsd/compare/loader_custom_rc >>>> -or- >>>> https://github.com/alfredperlstein/freebsd/compare/loader_custom_rc.di= ff >>>>=20 >>>>=20 >>>> Diff attached. >>>>=20 >>>> Also attached is a custom loader.rc file and loader.conf file that sho= ws how to set the brand/logo. >>>>=20 >>>> Please review. >>>>=20 >> I signed up for a github account (thanks), and I started commenting on s= ome lines. > yay! :) >>=20 >>>> -Alfred >>> >> Hmmm, I hadn't realized that you could say: >>=20 >> set foo=3Dbar >>=20 >> Along-side setting functions in the same file. >>=20 >> I don't think you can set functions in an *.rc file, only in a *.4th fil= e? >>=20 >> No? Maybe it's a false misconception of mine. I've been keeping them >> separate for years. (but probably rightfully so, to keep *.rc files clea= n). >=20 > It seems to work although I will talk to the team about making separate f= iles for the set commands. >=20 > I've responded to your review comments here: >=20 > https://github.com/alfredperlstein/freebsd/commit/0ca72dccd78b880b3e3ef4c= 2bb9ce025950a370b#commitcomment-4584862 >=20 > The changes I made are now in the branch > https://github.com/alfredperlstein/freebsd/tree/loader_custom_rc and you = likely should see them in the updated pull request I sent you. >=20 I improved on a few things... https://github.com/devinteske/freebsd/compare/freebsd:master...master -or- https://github.com/devinteske/freebsd/compare/freebsd:master...master.diff -or- Attached SVN patch.txt --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. --_002_BCC78B2C66F042C3AD53018637B2C433fisglobalcom_ Content-Type: text/plain; name="patch.txt" Content-Description: patch.txt Content-Disposition: attachment; filename="patch.txt"; size=3113; creation-date="Thu, 14 Nov 2013 07:54:54 GMT"; modification-date="Thu, 14 Nov 2013 07:54:54 GMT" Content-ID: <8FE81C1A7BC5C341B2E678BB7E03A797@fisglobal.com> Content-Transfer-Encoding: base64 SW5kZXg6IHN5cy9ib290L2ZvcnRoL2xvYWRlci40dGgNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBzeXMvYm9v dC9mb3J0aC9sb2FkZXIuNHRoCShyZXZpc2lvbiAyNTc4MjEpDQorKysgc3lzL2Jvb3QvZm9ydGgv bG9hZGVyLjR0aAkod29ya2luZyBjb3B5KQ0KQEAgLTIzMyw3ICsyMzMsMTYgQEAgaW5jbHVkZSAv Ym9vdC9jaGVjay1wYXNzd29yZC40dGgNCiAgIHMiIGRpc2FibGUtbW9kdWxlIiBzIiBkaXNhYmxl IGxvYWRpbmcgb2YgYSBtb2R1bGUiIC4/DQogICBzIiB0b2dnbGUtbW9kdWxlIiBzIiB0b2dnbGUg bG9hZGluZyBvZiBhIG1vZHVsZSIgLj8NCiAgIHMiIHNob3ctbW9kdWxlIiBzIiBzaG93IG1vZHVs ZSBsb2FkIGRhdGEiIC4/DQorICBzIiB0cnktaW5jbHVkZSIgcyIgdHJ5IHRvIGxvYWQvaW50ZXJw cmV0IGZpbGVzIiAuPw0KIDsNCiANCis6IHRyeS1pbmNsdWRlICggLS0gKSBcIHNlZSBsb2FkZXIu NHRoKDgpDQorICBbJ10gaW5jbHVkZSAoIC0tIHh0ICkgXCBnZXQgdGhlIGV4ZWN1dGlvbiB0b2tl biBvZiBgaW5jbHVkZScNCisgIGNhdGNoICggeHQgLS0gZXhjZXB0aW9uIyB8IDAgKSBpZiBcIGZh aWxlZA0KKyAgICBMRiBwYXJzZSAoIGMgLS0gcy1hZGRyL3UgKSAyZHJvcCBcIGFkdmFuY2UgPmlu IHRvIEVPTCAoZHJvcCBkYXRhKQ0KKyAgICBcIC4uLiBwcmV2ZW50cyB3b3JkcyB1bnVzZWQgYnkg YGluY2x1ZGUnIGZyb20gYmVpbmcgaW50ZXJwcmV0ZWQNCisgIHRoZW4NCis7IGltbWVkaWF0ZSBc IGludGVycHJldCBpbW1lZGlhdGVseSBmb3IgYWNjZXNzIHRvIGBzb3VyY2UnIChha2EgdGliKQ0K Kw0KIG9ubHkgZm9ydGggYWxzbw0KIA0KSW5kZXg6IHN5cy9ib290L2ZvcnRoL2xvYWRlci40dGgu OA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQ0KLS0tIHN5cy9ib290L2ZvcnRoL2xvYWRlci40dGguOAkocmV2aXNpb24g MjU3ODIwKQ0KKysrIHN5cy9ib290L2ZvcnRoL2xvYWRlci40dGguOAkod29ya2luZyBjb3B5KQ0K QEAgLTI0LDcgKzI0LDcgQEANCiAuXCINCiAuXCIgJEZyZWVCU0QkDQogLlwiDQotLkRkIE9jdG9i ZXIgMTcsIDIwMTMNCisuRGQgTm92ZW1iZXIgMTMsIDIwMTMNCiAuRHQgTE9BREVSLjRUSCA4DQog Lk9zDQogLlNoIE5BTUUNCkBAIC0xNTgsNiArMTU4LDEzIEBAIGZpbGVzIHRvIHNwZWNpZnkgdGhl IGFjdGlvbiBhZnRlciBhIG1vZHVsZSBsb2FkaW5nDQogVXNlZCBpbnNpZGUNCiAuWHIgbG9hZGVy LmNvbmYgNQ0KIGZpbGVzIHRvIHNwZWNpZnkgdGhlIGFjdGlvbiBhZnRlciBhIG1vZHVsZSBsb2Fk aW5nIGZhaWxzLg0KKy5JdCBJYyB0cnktaW5jbHVkZSBBciBmaWxlIE9wIEFyDQorUHJvY2VzcyBz Y3JpcHQgZmlsZXMgaWYgdGhleSBleGlzdC4NCitFYWNoIGZpbGUsIGluIHR1cm4sIGlzIGNvbXBs ZXRlbHkgcmVhZCBpbnRvIG1lbW9yeSwNCithbmQgdGhlbiBlYWNoIG9mIGl0cyBsaW5lcyBpcyBw YXNzZWQgdG8gdGhlIGNvbW1hbmQgbGluZSBpbnRlcnByZXRlci4NCitJZiBhbnkgZXJyb3IgaXMg cmV0dXJuZWQgYnkgdGhlIGludGVycHJldGVyLCB0aGUgdHJ5LWluY2x1ZGUNCitjb21tYW5kIGFi b3J0cyBpbW1lZGlhdGVseSwgd2l0aG91dCByZWFkaW5nIGFueSBvdGhlciBmaWxlcywgYW5kDQor c2lsZW50bHkgcmV0dXJucyB3aXRob3V0IGVycm9yLg0KIC5FbA0KIC5TaCBGSUxFUw0KIC5CbCAt dGFnIC13aWR0aCAvYm9vdC9sb2FkZXIuNHRoIC1jb21wYWN0DQpJbmRleDogc3lzL2Jvb3QvZm9y dGgvbG9hZGVyLnJjDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gc3lzL2Jvb3QvZm9ydGgvbG9hZGVyLnJjCShy ZXZpc2lvbiAyNTc4MjApDQorKysgc3lzL2Jvb3QvZm9ydGgvbG9hZGVyLnJjCSh3b3JraW5nIGNv cHkpDQpAQCAtMyw2ICszLDcgQEANCiBcDQogXCBJbmNsdWRlcyBhZGRpdGlvbmFsIGNvbW1hbmRz DQogaW5jbHVkZSAvYm9vdC9sb2FkZXIuNHRoDQordHJ5LWluY2x1ZGUgL2Jvb3QvbG9hZGVyLnJj LmxvY2FsDQogDQogXCBSZWFkcyBhbmQgcHJvY2Vzc2VzIGxvYWRlci5jb25mIHZhcmlhYmxlcw0K IFwgTk9URTogQ2hhbmdlIHRvIGBpbml0aWFsaXplJyBpZiB5b3UgZW5hYmxlIHRoZSBiZWxvdyBi b290IG1lbnUNCkluZGV4OiBzeXMvYm9vdC9mb3J0aC9tZW51LnJjDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g c3lzL2Jvb3QvZm9ydGgvbWVudS5yYwkocmV2aXNpb24gMjU3ODIwKQ0KKysrIHN5cy9ib290L2Zv cnRoL21lbnUucmMJKHdvcmtpbmcgY29weSkNCkBAIC0xMjAsNiArMTIwLDEwIEBAIHNldCBvcHRp b25zdG9nZ2xlZF9hbnNpWzZdPSIbWzFtVhtbMzdtZXJib3NlLi4uLi4NCiBcIA0KIHNldCBtZW51 X3RpbWVvdXRfY29tbWFuZD0iYm9vdCINCiANCitcIEluY2x1ZGUgb3B0aW9uYWwgZWxlbWVudHMg ZGVmaW5lZCBpbiBhIGxvY2FsIGZpbGUNCitcIA0KK3RyeS1pbmNsdWRlIC9ib290L21lbnUucmMu bG9jYWwNCisNCiBcIERpc3BsYXkgdGhlIG1haW4gbWVudSAoc2VlIGBtZW51LjR0aCcpDQogc2V0 IG1lbnVzZXRfaW5pdGlhbD0xDQogbWVudXNldC1sb2FkaW5pdGlhbA0KSW5kZXg6IHN5cy9ib290 L2kzODYvbG9hZGVyL2xvYWRlci5yYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHN5cy9ib290L2kzODYvbG9h ZGVyL2xvYWRlci5yYwkocmV2aXNpb24gMjU3NjUwKQ0KKysrIHN5cy9ib290L2kzODYvbG9hZGVy L2xvYWRlci5yYwkod29ya2luZyBjb3B5KQ0KQEAgLTMsNiArMyw3IEBADQogXA0KIFwgSW5jbHVk ZXMgYWRkaXRpb25hbCBjb21tYW5kcw0KIGluY2x1ZGUgL2Jvb3QvbG9hZGVyLjR0aA0KK3RyeS1p bmNsdWRlIC9ib290L2xvYWRlci5yYy5sb2NhbA0KIA0KIFwgUmVhZHMgYW5kIHByb2Nlc3NlcyBs b2FkZXIuY29uZiB2YXJpYWJsZXMNCiBpbml0aWFsaXplDQo= --_002_BCC78B2C66F042C3AD53018637B2C433fisglobalcom_--