Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 14 Apr 2006 16:10:20 GMT
From:      "Alan, Cheng-Lung Sung" <clsung@gmail.com>
To:        freebsd-bugs@FreeBSD.org
Subject:   Re: bin/89989: [patch] Add option to /usr/sbin/jail: -I (ASCII 73) PID to specify tryprid within jail(2)
Message-ID:  <200604141610.k3EGAKpd063254@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help 
The following reply was made to PR bin/89989; it has been noted by GNATS.

From: "Alan, Cheng-Lung Sung" <clsung@gmail.com>
To: bug-followup@FreeBSD.org, lannygodsey@yahoo.com
Cc:  
Subject: Re: bin/89989: [patch] Add option to /usr/sbin/jail: -I (ASCII 73) PID to specify tryprid within jail(2)
Date: Sat, 15 Apr 2006 00:02:07 +0800

 ------=_Part_26593_20063677.1145030527371
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 I think
 
 +       if (Iflag) {
 +               if (tryprid > 1) {
 +                       j.tryprid =3D tryprid;
 +               } else {
 +                       errx(1, "Requested JID out of range: %d", tryprid);
 +               }
 +       }
 
 should be
 
 +       if (Iflag) {
 +               if (tryprid > 0 && tryprid < JAIL_MAX) {
 +                       j.tryprid =3D tryprid;
 +               } else {
 +                       errx(1, "Requested JID out of range: %d", tryprid);
 +               }
 +       }
 
 right?
 
 --
 <clsung@FreeBSD.org>
 
 ------=_Part_26593_20063677.1145030527371
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 I think<br><pre>+       if (Iflag) {<br>+               if (tryprid &gt; 1)=
  {<br>+                       j.tryprid =3D tryprid;<br>+               } e=
 lse {<br>+                       errx(1, &quot;Requested JID out of range: =
 %d&quot;, tryprid);
 <br>+               }<br>+       }</pre>should be<br><pre>+       if (Iflag=
 ) {<br>+               if (tryprid &gt; 0 &amp;&amp; tryprid &lt; JAIL_MAX)=
  {<br>+                       j.tryprid =3D tryprid;<br>+               } e=
 lse {
 <br>+                       errx(1, &quot;Requested JID out of range: %d&qu=
 ot;, tryprid);<br>+               }<br>+       }</pre>
 right?<br clear=3D"all"><br>-- <br>&lt;<a href=3D"mailto:clsung@FreeBSD.org=
 ">clsung@FreeBSD.org</a>&gt;
 
 ------=_Part_26593_20063677.1145030527371--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604141610.k3EGAKpd063254>