Date: Tue, 2 Jan 2018 00:22:28 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Eugene Grosbein <eugen@grosbein.net> Cc: samm@os2.kiev.ua, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457814 - in head/sysutils/smartmontools: . files Message-ID: <E35A74BB-527C-4F1A-B630-4B1982448D0F@FreeBSD.org> In-Reply-To: <5A4AC199.7070400@grosbein.net> References: <201801012119.w01LJXE9054540@repo.freebsd.org> <5A4AC199.7070400@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 2 Jan 2018, at 00:17, Eugene Grosbein <eugen@grosbein.net> wrote: >=20 > 02.01.2018 4:19, Dimitry Andric =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> Author: dim (src committer) >> Date: Mon Jan 1 21:19:33 2018 >> New Revision: 457814 >> URL: https://svnweb.freebsd.org/changeset/ports/457814 >>=20 >> Log: >> Make smartmontools 6.6 compile with clang 6.0.0 and higher >>=20 >> Because clang 6.0.0 and higher default to -std=3Dgnu++14, like gcc 6 = and >> higher, compiling smartmontools results in the following error: >>=20 >> os_freebsd.cpp:487:45: error: invalid suffix on literal; C++11 = requires >> a space between literal and identifier = [-Wreserved-user-defined-literal] >> else if (sscanf(dev, NVME_CTRLR_PREFIX"%d"NVME_NS_PREFIX"%d%c", >> ^ >>=20 >> Fix this by adding spaces around the NVME_NS_PREFIX macro. This = makes >> the source C++14 compatible. >>=20 >> Approved by: samm@os2.kiev.ua (maintainer) >> PR: 224826 >> MFH: 2018Q1 >=20 > Why don't you just modify CFLAGS to set -std=3D... to right mode > corresponding to current coding style of smartmontools instead? Yes, that was also a possibility, which I mentioned in the PR (though one should put USE_CXXSTD=3D in the port Makefile instead). I think = this is more future-proof though. Some C++ programs are hard to adapt to C++11 or higher, but not this one. -Dimitry --Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWkrCtAAKCRCwXqMKLiCW o7k8AKDDp8L2DdF6Xf3cXUg/RdenvUjp8QCg75SUwysJNUhaY6h9Hbqlv8R0BS4= =q5ft -----END PGP SIGNATURE----- --Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E35A74BB-527C-4F1A-B630-4B1982448D0F>