From owner-freebsd-fs@freebsd.org Sat Feb 9 05:18:39 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99A6A14D78D9 for ; Sat, 9 Feb 2019 05:18:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 166F5857F1 for ; Sat, 9 Feb 2019 05:18:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C01B314D78D7; Sat, 9 Feb 2019 05:18:38 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD25414D78D6 for ; Sat, 9 Feb 2019 05:18:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2DE46857ED for ; Sat, 9 Feb 2019 05:18:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 491BEE0 for ; Sat, 9 Feb 2019 05:18:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x195IbDl019030 for ; Sat, 9 Feb 2019 05:18:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x195IbUj019029 for fs@FreeBSD.org; Sat, 9 Feb 2019 05:18:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 235582] rpc_svc_gss / nfsd kernel panic Date: Sat, 09 Feb 2019 05:18:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2019 05:18:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235582 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201858|0 |1 is obsolete| | --- Comment #7 from Rick Macklem --- Created attachment 201862 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D201862&action= =3Dedit updated fix for srv side rpcsec_gss NULL client principal This is an update to the 201858 patch which does a couple of printf()s and no KASSERT(). It uses a local clname instead of the one in client->cl_cname so that any race caused by multiple RPC requests with the same handle and GSS_S_CONTINUE_INIT will be handled. (gss_release_name() sets client->cl_cname NULL and that could have resulted in the crash if multiple RPCs were received and handled concurrently as above.) I didn't think that gss_accept_sec_context() ever returned GSS_S_CONTINUE_INIT for Kerberos mechanism, but I could be wrong on this and if this does happen and the client erroneously sends the next token RPC twice, it could try to use client->cl_cname after it is set NULL by the gss_release_name() for the previous RPC message. The printf()s should tell us more about how the NULL cname happens. --=20 You are receiving this mail because: You are the assignee for the bug.=