Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2014 08:02:53 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r261505 - head/sys/dev/usb
Message-ID:  <201402050802.s1582rib018547@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Wed Feb  5 08:02:52 2014
New Revision: 261505
URL: http://svnweb.freebsd.org/changeset/base/261505

Log:
  Fix a regression issue. Contiguous single segment allocations above
  PAGE_SIZE bytes should only use one USB page structure. Fixes a
  problem with some external drivers.
  
  MFC after:	2 days

Modified:
  head/sys/dev/usb/usb_busdma.c

Modified: head/sys/dev/usb/usb_busdma.c
==============================================================================
--- head/sys/dev/usb/usb_busdma.c	Wed Feb  5 04:39:03 2014	(r261504)
+++ head/sys/dev/usb/usb_busdma.c	Wed Feb  5 08:02:52 2014	(r261505)
@@ -452,7 +452,7 @@ usb_pc_common_mem_cb(void *arg, bus_dma_
 		goto done;
 	}
 #endif
-	while (1) {
+	while (pc->ismultiseg) {
 		off += USB_PAGE_SIZE;
 		if (off >= (segs->ds_len + rem)) {
 			/* page crossing */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402050802.s1582rib018547>