From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 25 15:20:08 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1978A10656D2 for ; Wed, 25 Mar 2009 15:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E3F9D8FC16 for ; Wed, 25 Mar 2009 15:20:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2PFK7SN039606 for ; Wed, 25 Mar 2009 15:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2PFK79v039600; Wed, 25 Mar 2009 15:20:07 GMT (envelope-from gnats) Resent-Date: Wed, 25 Mar 2009 15:20:07 GMT Resent-Message-Id: <200903251520.n2PFK79v039600@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mateusz Guzik Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53C5010657EA for ; Wed, 25 Mar 2009 15:14:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 3C1B68FC0C for ; Wed, 25 Mar 2009 15:14:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2PFEGQk032500 for ; Wed, 25 Mar 2009 15:14:16 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n2PFEFYG032498; Wed, 25 Mar 2009 15:14:15 GMT (envelope-from nobody) Message-Id: <200903251514.n2PFEFYG032498@www.freebsd.org> Date: Wed, 25 Mar 2009 15:14:15 GMT From: Mateusz Guzik To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/133064: [sysv] Missing free(sema_mtx, M_SEM) in sys/kern/sysv_sem.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2009 15:20:10 -0000 >Number: 133064 >Category: kern >Synopsis: [sysv] Missing free(sema_mtx, M_SEM) in sys/kern/sysv_sem.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 25 15:20:07 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Mateusz Guzik >Release: 8.0-CURRENT >Organization: >Environment: >Description: seminit() allocates memory for sema_mtx, but semunload() does not free it. >How-To-Repeat: >Fix: Call free(sema_mtx, M_SEM) in semunload(). Patch attached with submission follows: --- sysv_sem.c.orig 2009-01-15 12:15:46.000000000 +0000 +++ sysv_sem.c 2009-03-25 14:44:25.000000000 +0000 @@ -285,6 +285,7 @@ free(semu, M_SEM); for (i = 0; i < seminfo.semmni; i++) mtx_destroy(&sema_mtx[i]); + free(sema_mtx, M_SEM); mtx_destroy(&sem_mtx); mtx_destroy(&sem_undo_mtx); return (0); >Release-Note: >Audit-Trail: >Unformatted: