From nobody Wed Dec 6 08:46:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SlWH62rYGz535JD for ; Wed, 6 Dec 2023 08:46:58 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Received: from smtp-8fab.mail.infomaniak.ch (smtp-8fab.mail.infomaniak.ch [83.166.143.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SlWH56rwsz3FbL for ; Wed, 6 Dec 2023 08:46:57 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from smtp-2-0001.mail.infomaniak.ch (unknown [10.5.36.108]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4SlWH32hxWzMq3cT; Wed, 6 Dec 2023 08:46:55 +0000 (UTC) Received: from unknown by smtp-2-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4SlWH26tpvzMpnyw; Wed, 6 Dec 2023 09:46:54 +0100 (CET) Message-ID: Date: Wed, 6 Dec 2023 09:46:53 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 14dcd4098374 - main - linuxkpi: `GFP_KERNEL` equals `M_NOWAIT` now Content-Language: fr, en-US To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202311241731.3AOHVsEJ061730@gitrepo.freebsd.org> From: =?UTF-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= Organization: The FreeBSD Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Infomaniak-Routing: alpha X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:83.166.128.0/19, country:CH] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SlWH56rwsz3FbL On 06/12/2023 00:52, Konstantin Belousov wrote: > Unfortunately this broke even attach of the mlx5(4) driver. > According to the 'official' Linux kernel documentation, the GFP_KERNEL > flag implies sleepable context. mlx5_core uses the passed GFP flag to > determine if it is called in the sleepable context, and now even initial > load assumes that it cannot perform sleeping ops. See, for instance, > second if() statement in the mlx5_fwp_alloc() function. Oh sorry... Thank you for reporting the issue. I will revisit this change then. Should I revert it in main until there is a solution? -- Jean-Sébastien Pédron The FreeBSD Project