Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Apr 2020 17:53:36 +0200
From:      Mathieu Arnold <mat@freebsd.org>
To:        Emanuel Haupt <ehaupt@freebsd.org>
Cc:        Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r530864 - head/audio/fasttracker2
Message-ID:  <20200406155336.bjshfwz7ueq5bjp2@aching.in.mat.cc>
In-Reply-To: <20200406152927.64594364bfe06cd5be79d373@FreeBSD.org>
References:  <202004060736.0367a5jk032226@repo.freebsd.org> <20200406123833.GA45635@FreeBSD.org> <20200406152927.64594364bfe06cd5be79d373@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--qoojie443r2jwmon
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 06, 2020 at 03:29:27PM +0200, Emanuel Haupt wrote:
> Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Mon, Apr 06, 2020 at 07:36:05AM +0000, Emanuel Haupt wrote:
> > > New Revision: 530864
> > > URL: https://svnweb.freebsd.org/changeset/ports/530864
> > >=20
> > > Log:
> > >   - Restore accidentally removed Makefile header
> > >   - Provide an option to build with pulseaudio
> > >=20
> > > ...
> > > @@ -29,14 +32,17 @@ DESKTOP_ENTRIES=3D"FastTracker II" \
> > > =20
> > >  PLIST_FILES=3D	bin/fasttracker2 share/pixmaps/ft2-clone.ico
> > > =20
> > > -OPTIONS_DEFINE=3D	ALSA
> > > -OPTIONS_DEFAULT=3DALSA
> > > +OPTIONS_DEFINE=3D	ALSA PULSEAUDIO
> > > +OPTIONS_DEFAULT=3DALSA PULSEAUDIO
> >=20
> > We typically do not enable PA by default in FreeBSD ports because
> > it's mainly Linuxish piece of software, unneeded under FreeBSD as
> > we have superior sound stack which offers similar, but better placed
> > and implemented functionality by itself.  It may be helpful in some
> > bizarre edge case usage scenario (which justifies having it as an
> > OPTION), but for most users r530864 would pull needless and often
> > unwanted dependency.
>=20
> I'll keep that in mind for the next update (upstream has short release
> cycles).

Hi,

Unless upstream has a release cycle of a day, why not simply remove
PULSEAUDIO fron the OPTIONS_DEFAULT line and commit just that?

--=20
Mathieu Arnold

--qoojie443r2jwmon
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl6LUHxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgJ0/xAAmefgZn/UpOiH6AbMTQSpbACCwDtUPn48nw1Nu3rG+T/fjFJt9N4EqoOS
RXRgTM15OT+hHAopxYK5yiRd5Ty4CHvi6wwyKdrafQukolgyuBX1+dTQ0dDpk9q/
8qLDM6Qn2nV61/BOqQsG6ebwlYiwfjuecC/j24jP9WyNKR4r++tnZXOne7i+WbJ3
YJnYqbF/S67uqpJWzZCV/NKu8TjZUExiP/TkHufnANnkieGraTEAwST/sUdbHawe
BjBzfgm13vrQUmzRCV2xvkF1vpoHrzcFjcUtB6fKjHWLgKjCjF4G2Xd7nZMAlWxW
nES2uTrQ9dLCLR8Pe+4QlqNoQHvfd+76GxHUO9mR3Di9fd5+GIfWU0xO0C8s4dzu
6fuu7d2W6X8YZDum97F5xANPWbsn2XxqXcjEpJNd75jB7QQLOdcncNBP5UFK0v3n
VE9dhdS7QGThKvV4i4UbzsXoQl+3D8g+Xp1JE+O3HnVAK2LIKUQz/Ro/fRvHm9Tn
SJS/CgqJIgYWgjw7SWUcRT9GxwIiwFI0vSd+2hVf7ybmVXeGFGrq7tJ1FjFNdZ+u
kBf4K9bYwI1A+9RHyMURB0hvb4jOaQZjeBc9Mc33tkRtDfD4mFWLF7Nf3Hwuz+en
ujTFN1m0Kkri/oXGP3shCkWfbYSH7hcPbvr0HXNpSibATdYmHC8=
=vNc4
-----END PGP SIGNATURE-----

--qoojie443r2jwmon--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200406155336.bjshfwz7ueq5bjp2>