Date: Wed, 18 Aug 2004 12:27:25 -0600 From: Scott Long <scottl@samsco.org> To: John Polstra <jdp@polstra.com> Cc: Julian Elischer <julian@elischer.org> Subject: Re: netgraph only on i386/ia64 - why ? Message-ID: <41239F8D.4000808@samsco.org> In-Reply-To: <XFMail.20040818112451.jdp@polstra.com> References: <XFMail.20040818112451.jdp@polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John Polstra wrote: > On 18-Aug-2004 Julian Elischer wrote: > >>John Polstra wrote: >> >>>There is one problem with netgraph on 64-bit platforms. The ng_msghdr >>>struct is 52 bytes / 4-byte aligned (see ng_message.h). That means >>>the message payload is not well-aligned for 64-bit platforms. It >>>would be nice to fix that (and bump NG_VERSION, of course). Nobody >>>ever guaranteed that the message payload would be aligned, but it >>>makes things a lot more convenient. >> >>if we do this we should do it now so that we have a consistent ABI from 5.3 on.. >> >>scott (et al), should we pad an extra 4 bytes in this now? >>it's low/no risk, but better now than after 5.3 has been released.. > > > I'd really like to see this change happen. Julian, would it require > bumping just NG_VERSION, or should NG_ABI_VERSION change too? > > John The first step here is to commit to HEAD. Once the details are worked out, we'll likely approve it for RELENG_5. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41239F8D.4000808>