From owner-svn-ports-head@freebsd.org Mon Jan 1 23:22:38 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95C6CE8AC36; Mon, 1 Jan 2018 23:22:38 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4EF10389D; Mon, 1 Jan 2018 23:22:37 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 5FCBCC4BA; Tue, 2 Jan 2018 00:22:29 +0100 (CET) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r457814 - in head/sysutils/smartmontools: . files Date: Tue, 2 Jan 2018 00:22:28 +0100 In-Reply-To: <5A4AC199.7070400@grosbein.net> Cc: samm@os2.kiev.ua, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org To: Eugene Grosbein References: <201801012119.w01LJXE9054540@repo.freebsd.org> <5A4AC199.7070400@grosbein.net> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jan 2018 23:22:38 -0000 --Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 2 Jan 2018, at 00:17, Eugene Grosbein wrote: >=20 > 02.01.2018 4:19, Dimitry Andric =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> Author: dim (src committer) >> Date: Mon Jan 1 21:19:33 2018 >> New Revision: 457814 >> URL: https://svnweb.freebsd.org/changeset/ports/457814 >>=20 >> Log: >> Make smartmontools 6.6 compile with clang 6.0.0 and higher >>=20 >> Because clang 6.0.0 and higher default to -std=3Dgnu++14, like gcc 6 = and >> higher, compiling smartmontools results in the following error: >>=20 >> os_freebsd.cpp:487:45: error: invalid suffix on literal; C++11 = requires >> a space between literal and identifier = [-Wreserved-user-defined-literal] >> else if (sscanf(dev, NVME_CTRLR_PREFIX"%d"NVME_NS_PREFIX"%d%c", >> ^ >>=20 >> Fix this by adding spaces around the NVME_NS_PREFIX macro. This = makes >> the source C++14 compatible. >>=20 >> Approved by: samm@os2.kiev.ua (maintainer) >> PR: 224826 >> MFH: 2018Q1 >=20 > Why don't you just modify CFLAGS to set -std=3D... to right mode > corresponding to current coding style of smartmontools instead? Yes, that was also a possibility, which I mentioned in the PR (though one should put USE_CXXSTD=3D in the port Makefile instead). I think = this is more future-proof though. Some C++ programs are hard to adapt to C++11 or higher, but not this one. -Dimitry --Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWkrCtAAKCRCwXqMKLiCW o7k8AKDDp8L2DdF6Xf3cXUg/RdenvUjp8QCg75SUwysJNUhaY6h9Hbqlv8R0BS4= =q5ft -----END PGP SIGNATURE----- --Apple-Mail=_20C47A5B-86C5-429C-980C-99D007C60363--