From owner-svn-src-head@freebsd.org  Thu Sep 10 14:26:44 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0E5693D8CC2;
 Thu, 10 Sep 2020 14:26:44 +0000 (UTC)
 (envelope-from andrew@freebsd.org)
Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16])
 by mx1.freebsd.org (Postfix) with ESMTP id 4BnLmg5CZZz44mr;
 Thu, 10 Sep 2020 14:26:43 +0000 (UTC)
 (envelope-from andrew@freebsd.org)
Received: from [192.168.42.12]
 (cpc91220-cmbg18-2-0-cust60.5-4.cable.virginm.net [81.104.142.61])
 by fry.fubar.geek.nz (Postfix) with ESMTPSA id 9AC6F4E70F;
 Thu, 10 Sep 2020 14:26:06 +0000 (UTC)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\))
Subject: Re: svn commit: r365578 - head/stand/efi/loader/arch/arm64
From: Andrew Turner <andrew@freebsd.org>
In-Reply-To: <105aee92-6efe-4022-9ffb-b49a79b384b3@www.fastmail.com>
Date: Thu, 10 Sep 2020 15:26:05 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <044B70B9-21D2-4143-8EFF-9EA716BFC108@freebsd.org>
References: <202009101413.08AEDnUc006616@repo.freebsd.org>
 <105aee92-6efe-4022-9ffb-b49a79b384b3@www.fastmail.com>
To: Brandon Bergren <bdragon@FreeBSD.org>
X-Mailer: Apple Mail (2.3445.104.15)
X-Rspamd-Queue-Id: 4BnLmg5CZZz44mr
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
 ASN(0.00)[asn:14061, ipnet:139.59.160.0/20, country:US]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Sep 2020 14:26:44 -0000

We already discard it via objcopy when converting from elf -> EFI as we =
only copy the sections needed in the final EFI file.

Andrew

> On 10 Sep 2020, at 15:22, Brandon Bergren <bdragon@FreeBSD.org> wrote:
>=20
> You can truly get rid of it with /DISCARD/ and shave the bytes off =
entirely, by the way.
>=20
> On Thu, Sep 10, 2020, at 9:13 AM, Andrew Turner wrote:
>> Author: andrew
>> Date: Thu Sep 10 14:13:49 2020
>> New Revision: 365578
>> URL: https://svnweb.freebsd.org/changeset/base/365578
>>=20
>> Log:
>>  Ignore the .interp section in the arm64 EFI loader
>>=20
>>  When building the loader an unneeded .interp section may be added. =
Move
>>  this to the unused section region so offsets of used sections don't
>>  change.
>>=20
>>  Obtained from:	CheriBSD
>>  Sponsored by:	Innovate UK
>>=20
>> Modified:
>>  head/stand/efi/loader/arch/arm64/ldscript.arm64
>>=20
>> Modified: head/stand/efi/loader/arch/arm64/ldscript.arm64
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/stand/efi/loader/arch/arm64/ldscript.arm64	Thu Sep 10 =
14:12:25=20
>> 2020	(r365577)
>> +++ head/stand/efi/loader/arch/arm64/ldscript.arm64	Thu Sep 10 =
14:13:49=20
>> 2020	(r365578)
>> @@ -80,6 +80,7 @@ SECTIONS
>>   _edata =3D .;
>>=20
>>   /* Unused sections */
>> +  .interp	: { *(.interp) }
>>   .dynstr	: { *(.dynstr) }
>>   .hash		: { *(.hash) }
>> }
>>=20
>=20
> --=20
>  Brandon Bergren
>  bdragon@FreeBSD.org
>=20