From nobody Wed Apr 22 21:08:03 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1Bdc1v3Jz6bKnf for ; Wed, 22 Apr 2026 21:08:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1Bdb4pZtz3kWB for ; Wed, 22 Apr 2026 21:08:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776892083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kLEgNuMs2/N5OYUFNzIHuBynswHPIMSSdNcJ3f87/gQ=; b=D2KcgDlmd8bU9tiyi/IUm/59aYGXb/NtviroSo3Cgpy2yrwaZZJ8fnkvFB97l/iesgGwb5 FSU1rld4Xe+71FXmUoEubXbqA4AAbufunrCQ01+PZIOZnC9L2mJD5875mBY9GXzAe3fgIk NS5S8yLSAIEEK0Qq52ThTbUwv8z0Z2zndHF0NWW5DS6QbW28wjFZwCjIMxw3beVMn9uDdV dBEMpdcuxUrVPwZ47OnY3XOn+Ghn0cS5x47gJaZbJp/5YUUwaPQ/6cMuqMto1L6TYkfkKF qLqFx77M+bOG8YTC1QWkLvdKdwVLt3k/g3ckc/5AO7JRM4Gv5Df9d/ELmj48nQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776892083; a=rsa-sha256; cv=none; b=SJQ86jegQsgyBXlNJjJT4F4YgEbMSq38hZr6abvcwp9jkzZFTqBhhbNdyvxzmy5O7GgaBN syTdkH+sJ7ERY5/FC3ZR96k9axcqh92rCdXs0nNhxAxf2OHkhe2aLIjZztMTt8Kx7hormP mdgqu9eYaAuvJjs4wzyeHtmzbHOzHTPgV1uY5vtFADAnmsuoS7UabbQe6zAbpaHw0FYxmZ bXEpS+m1KDXhgUw0na+jovzIy+O69wOmec7sebWx9DbyQdr0RqcBH/aidWBs6KiGNUuyOy zLP86B4O/v2GWfn0rcJ7tJxqdyO/j17mkpmsrR01DEMAWVijPXUS4wxvqtbrFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776892083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kLEgNuMs2/N5OYUFNzIHuBynswHPIMSSdNcJ3f87/gQ=; b=PTH1taKASwrY8SLImE22O2fkpNvitB33tT5JP0OmR80tLM2G/IpF64JLoKlY8dhYId559j m3NmoJVGDf5FpxMP3Dk0g4Wy3syhm1YEVg8ogq3oeAQ5UopC7+nn4F4k2mlf6HSbgNOCtf QFxmyPg3QG1+Q0rqJaoBxIqyWxTFZBkZ3JR+3NZYFMa6o4QRO4uDkoUNQnLyhekFbv0K8n MuF5gFV0P/Q5D7ajrdI7IcVeoK07QksVo/6qjiJ3ApyCMrEo5TxBAiaeItRSkgBtvk17aa B7jgyH8QrBMu+SCHtZuhUwXPPYuTFnnsa+pAg28JRuE05TBa1yu6ABHk7L65GQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g1Bdb4GcpznZG for ; Wed, 22 Apr 2026 21:08:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27ca4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 21:08:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Jean-=?utf-8?Q?S=C3=A9bast?==?utf-8?Q?ien P=C3=A9?=dron From: Bjoern A. Zeeb Subject: git: de8bc3aad7f1 - stable/15 - linuxkpi: Define `PCI_POSSIBLE_ERROR()` macro List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: de8bc3aad7f1b8eff5258b16e67bd2cc32275e20 Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 21:08:03 +0000 Message-Id: <69e938b3.27ca4.3aec0a0b@gitrepo.freebsd.org> The branch stable/15 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=de8bc3aad7f1b8eff5258b16e67bd2cc32275e20 commit de8bc3aad7f1b8eff5258b16e67bd2cc32275e20 Author: Jean-Sébastien Pédron AuthorDate: 2025-08-09 16:14:05 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-04-22 20:56:53 +0000 linuxkpi: Define `PCI_POSSIBLE_ERROR()` macro It comes with `PCI_ERROR_RESPONSE` and `PCI_SET_ERROR_RESPONSE()` but we don't use them so far. Therefore `PCI_POSSIBLE_ERROR()` will always reture false. As written in the comment, this macro is a bit weird given the Linux `pci_read_*() functions can return an error code separately from the read value. The `PCI_POSSIBLE_ERROR()` macro started to be used by the amdgpu DRM driver in Linux 6.10. Reviewed by: emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D54487 (cherry picked from commit ace666bd21a204c62807f2c899402a7dc9ab161a) --- sys/compat/linuxkpi/common/include/linux/pci.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sys/compat/linuxkpi/common/include/linux/pci.h b/sys/compat/linuxkpi/common/include/linux/pci.h index 9b7699a5ca59..ccbd425de5da 100644 --- a/sys/compat/linuxkpi/common/include/linux/pci.h +++ b/sys/compat/linuxkpi/common/include/linux/pci.h @@ -235,6 +235,20 @@ extern const char *pci_power_names[6]; #define PCI_IRQ_LEGACY PCI_IRQ_INTX #endif +/* + * Linux PCI code uses `PCI_SET_ERROR_RESPONSE()` to indicate to the caller of + * a `pci_read_*()` function that the read failed. An example of failure is + * whether the device was disconnected. It is a bit weird because Linux + * `pci_read_*()` can return an error value, as the read value is stored in a + * integer passed by pointer. + * + * We don't set PCI_ERROR_RESPONSE anywhere as of this commit, but the DRM + * drivers started to use `PCI_POSSIBLE_ERROR()`. + */ +#define PCI_ERROR_RESPONSE (~0ULL) +#define PCI_SET_ERROR_RESPONSE(val) (*(val) = ((typeof(*(val))) PCI_ERROR_RESPONSE)) +#define PCI_POSSIBLE_ERROR(val) ((val) == ((typeof(val)) PCI_ERROR_RESPONSE)) + struct pci_dev; struct pci_driver {