From owner-svn-src-head@freebsd.org  Fri Feb  1 01:01:27 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D865114BE210;
 Fri,  1 Feb 2019 01:01:27 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2289A8484B;
 Fri,  1 Feb 2019 01:01:26 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x1111HmX001123
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 1 Feb 2019 03:01:20 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x1111HmX001123
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id x1111HtB001122;
 Fri, 1 Feb 2019 03:01:17 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Fri, 1 Feb 2019 03:01:17 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: araujo@freebsd.org
Cc: Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r343634 - head/usr.sbin/bhyve
Message-ID: <20190201010117.GA24863@kib.kiev.ua>
References: <201901312332.x0VNWJ6o016057@repo.freebsd.org>
 <20190131234609.GZ24863@kib.kiev.ua>
 <CANCZdfoL=n2Bo-waSfNth2Q-ZN8Ej+vZ6_no7QWSRnNfQnAqxA@mail.gmail.com>
 <CAOfEmZhi+j5D0KvSSE0HjwNZGiko5eGLtviFRdbBrk31g-GB+w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOfEmZhi+j5D0KvSSE0HjwNZGiko5eGLtviFRdbBrk31g-GB+w@mail.gmail.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2019 01:01:28 -0000

On Fri, Feb 01, 2019 at 08:40:11AM +0800, Marcelo Araujo wrote:
> Em sex, 1 de fev de 2019 às 08:36, Warner Losh <imp@bsdimp.com> escreveu:
> 
> >
> >
> > On Thu, Jan 31, 2019, 4:46 PM Konstantin Belousov <kostikbel@gmail.com
> > wrote:
> >
> >> On Thu, Jan 31, 2019 at 11:32:19PM +0000, Marcelo Araujo wrote:
> >> > Author: araujo
> >> > Date: Thu Jan 31 23:32:19 2019
> >> > New Revision: 343634
> >> > URL: https://svnweb.freebsd.org/changeset/base/343634
> >> >
> >> > Log:
> >> >   Mostly a cosmetic change to replace strlen with strnlen.
> >> This is not cosmetic, and more, for instance the usage() part of the
> >> change
> >> does not make any sense to me.
> >>
> >
> > I specifically objected as well and was blown off. What gives?
> >
> 
> I have asked you feedback and got none! I will revert the usage() changes
> later then.

I noted the usage() chunk because it is the first one in the commit and
I stopped after I see the obvious issues with it, not because it is the
only wrong part.