Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Jun 1998 15:09:31 +0200 (MET DST)
From:      Ugo Paternostro <paterno@dsi.UNIFI.IT>
To:        freebsd-stable@FreeBSD.ORG
Subject:   PnP support for if_ed, and more...
Message-ID:  <XFMail.980601150931.paterno@dsi.unifi.it>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
I backported PnP support for if_ed from -current to -stable (hey, that was a
lot of cut and paste... :-), and submitted it as PR i386/6792. Would please
somebody with commit privileges bring that into -stable? TIA.

BTW, as I said in the PR, there's a PnP ID in my patch that should be committed
to -current too (the WSC9008 id).

As you are there, please commit the attached patch to sio.c to enable the
SupraExpress 56i Sp PnP detection, both in -stable and -current.

Isn't there a way to avoid this mess of patching both releases when you want to
add a PnP ID? Could we have some file to #include at the right point (to
minimize name space pollution) in both -stable and -current, where we define the
IDs? Maybe something like:

siopnp.h:
---------------------------
struct pnp_ids {
        u_long vend_id;
        char *id_str;
};

#define SIOPNP_IDS { { 0x8113b04e, "Supra1381"} ... }
---------------------------

sio.c:
---------------------------
...
#if NPNP > 0
#include "siopnp.h"
static struct pnp_ids siopnp_ids[] = SIOPNP_IDS;
...
#endif
---------------------------

Better: the pnp_ids definition should *NOT* live in siopnp.h, but in pnp.h, as
that's shared with if_ed and so on.

I could easily submit a full-blown-ready-to-commit-set-of-patches, if you
like... :-)

Bye, UP


[-- Attachment #2 --]
Index: src/sys/i386/isa/sio.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/isa/sio.c,v
retrieving revision 1.147.2.15
diff -u -r1.147.2.15 sio.c
--- sio.c	1998/05/06 19:09:13	1.147.2.15
+++ sio.c	1998/05/31 12:32:08
@@ -2689,6 +2689,7 @@
 } siopnp_ids[] = {
 	{ 0x8113b04e, "Supra1381"},
 	{ 0x9012b04e, "Supra1290"},
+	{ 0x7121b04e, "SupraExpress 56i Sp"},
 	{ 0x11007256, "USR0011"},
 	{ 0 }
 };

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.980601150931.paterno>