From owner-freebsd-current@FreeBSD.ORG  Tue Jan 13 16:37:35 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1255B16A4CE; Tue, 13 Jan 2004 16:37:35 -0800 (PST)
Received: from coconut.itojun.org (coconut.itojun.org [219.101.47.130])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1B0BE43D4C; Tue, 13 Jan 2004 16:37:34 -0800 (PST)
	(envelope-from itojun@itojun.org)
Received: by coconut.itojun.org (Postfix, from userid 1001)
	id E0024A0; Wed, 14 Jan 2004 09:37:32 +0900 (JST)
To: bzeeb-lists@lists.zabbadoz.net
In-Reply-To: Your message of "Tue, 13 Jan 2004 12:31:24 +0900 (JST)"
	<20040113033124.7F7BDA6@coconut.itojun.org>
References: <20040113033124.7F7BDA6@coconut.itojun.org>
X-Mailer: Cue version 0.6 (031125-1130/itojun)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Message-Id: <20040114003732.E0024A0@coconut.itojun.org>
Date: Wed, 14 Jan 2004 09:37:32 +0900 (JST)
From: itojun@itojun.org (Jun-ichiro itojun Hagino)
X-Mailman-Approved-At: Tue, 13 Jan 2004 17:07:57 -0800
cc: sam@freebsd.org
cc: re@freebsd.org
cc: current@freebsd.org
cc: core@kame.net
cc: bzeeb+freebsd@zabbadoz.net
cc: ume@freebsd.org
Subject: Re: [PATCH] IPSec fixes
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jan 2004 00:37:35 -0000

> > http://sources.zabbadoz.net/freebsd/patchset/110-ipsec-netkey-key.diff
> 	dunno if it is correct or not.  need more investigation.

	location of key_freesp() are wrong (you end up dereference freed
	pointer on ipseclog() because you call key_freesp() beforehand).
	other than that, those key_freesp() are needed.  thanks.

	as for key_sp_unlink(), i don't think the patch is correct.
	even if you do not call key_sp_unlink() in key_spdflush(), spd entries
	will get unlink'ed in key_timehandler().  therefore the end result
	will be the same.

itojun