From nobody Thu Feb 16 07:57:38 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHS3X4yZ6z3pKbK for ; Thu, 16 Feb 2023 07:57:44 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHS3X4R4xz3JD1; Thu, 16 Feb 2023 07:57:44 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676534264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wPAPOIjCJxq2PWcC5mDldM4w/mVi9DE4Np+psJ9QAJ8=; b=J+rvRgqGe2gHeEzlE/HC+LkBTZbSXEhp0412aj8uLv+7LRI4OU9UABytEU11s9Tc4X047j ca5OAXLEGJFfPZBYBuz71fESgynId4f8pLCe7J/rvDUW2dz50hXhhH64k/461jNwRfj2fz NbIoJAVT52QqiXOdBUyynzsi4Y6DpIovaodG+f9dl4hHd66Uvm6K1sXTHx7xz6uHXS7MgA Bwjlpdq05eRUramVQ1JtmXOOuL/Ni1Tke9WpCl07/pcPo7FpCYb1FPwcHMyy6WGvgNieOO 36JzI6d33CMjpHVsER2BDvZdVUnlADTIze+MwBHOqQ++qx7v6BjQaO4GSw+psQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676534264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wPAPOIjCJxq2PWcC5mDldM4w/mVi9DE4Np+psJ9QAJ8=; b=gKBUrSbW6so+/jeXvBUMKOQTk2rEACTOqS0OD/ofcQv0+ALyrCx5kfB/nIhEcmp7X15xQo 6b8OMMejG+6+moqAZoyXEwCsRYSqNol+xWrqaF21KYMheyMogR+AmyZ8Ht5kMHwYYazTwR XVe77EITlzOG5H2EVMV6KQcVtgLPHn0Ac8V1TaJEDuU8Mpc/KidUDBEpUh3l14zgSfe83M E1mZsFls3iuFGxhASj3sbHqjMKMJ812dpasvcDydUCeoEZfxHK+TGu2TY4sE8adnZZMq4x sX49MnK2YtynIn+Gieb2nQupNXW8cWqvrkT0wrEe0QII+xIH/XvxcdNkEABiYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676534264; a=rsa-sha256; cv=none; b=aYFFrCF7kEpelwDqreujJ22caYX0mbNcmFrPenZEAYY1igWxc79hxhGW04st7L2Vr4ucQx HCrQg+UwulLFdrCB0+canttncSBiBgzjxWdn1hpYCL64YK9mFICjLykVV76mG5xsiMk0tY jFAeHko0QkOhTXNV33Gc78RzzbubouFFQmcoVYWUqgzE+l7adRxtfeqnK2b2XoRsfXN/zM wYGoUwE4bDo9E5ZknfN0WxQI5/gPxYZ5udO1uZYCjvVyRR4+rJahuLq3dTcka2l00dR/yd ocH1vUrhGMitokiQYm/LBgCx1SyQmO6s2VogGc2gVOBIPxwXK/kG/HdP5oFX7A== Received: from localhost (p200300cb871a694eb5fedb6a75c132cd.dip0.t-ipconnect.de [IPv6:2003:cb:871a:694e:b5fe:db6a:75c1:32cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PHS3X0QBRz1Qh9; Thu, 16 Feb 2023 07:57:43 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Thu, 16 Feb 2023 08:57:38 +0100 From: Gordon Bergling To: Warner Losh Cc: Gordon Bergling , FreeBSD Current Subject: Re: Build breakage with WITH_BEARSSL=1 Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7oN4/LC7dxEXkojl" Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 8:54AM up 15:16, 2 users, load averages: 0.50, 0.39, 0.27 X-ThisMailContainsUnwantedMimeParts: N --7oN4/LC7dxEXkojl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Warner, On Wed, Feb 15, 2023 at 10:07:08AM -0700, Warner Losh wrote: > On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: > > > >> Hi, > >> > >> I am currently seeing a build breakage when building -CURRENT with > >> WITH_BEARSSL=3D1. > >> > >> The error is the following > >> > >> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: > >> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.a= sc 2> > >> /dev/null" returned non-zero status > >> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: > >> a function declaration without a prototype is deprecat ed in all vers= ions > >> of C [-Werror,-Wstrict-prototypes] > >> br_rsa_i62_keygen_get() > >> ^ > >> void > >> 1 error generated. > >> --- rsa_i62_keygen.pico --- > >> > >> > >> When disabling BEARSSL in the src.conf the build succeeds as usual. > >> > >> Has anyone also seen this build error. Sources are very recent and the > >> src.conf is the following: > >> > >> WITH_EXTRA_TCP_STACKS=3D1 > >> #WITH_BEARSSL=3D1 > >> WITH_PIE=3D1 > >> WITH_RETPOLINE=3D1 > >> WITH_INIT_ALL_ZERO=3D1 > >> WITH_OPENSSL_KTLS=3D1 > >> WITHOUT_CLEAN=3D1 > >> > >> Any help is very appreciated. > >> > >> > > What does the following do for you? It's a cut and pasted patch, but it > > should be clear enough what to do if the mailer mangles it. > > > > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc > > index dd0e242c8ef0..2af4864d8441 100644 > > --- a/lib/libbearssl/Makefile.inc > > +++ b/lib/libbearssl/Makefile.inc > > @@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl > > BEARSSL_SRC=3D ${BEARSSL}/src > > > > CFLAGS+=3D -I${BEARSSL}/inc > > - > > +CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE} > > >=20 > I went ahead and committed this. Please let me know if the problem persis= ts. Sorry for the late reply. I just tried a fresh build and it still fails with [..]/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a function declaration without a prototype is deprecated in all versions of C [-Werror= ,-Wstrict-prototypes] br_rsa_i62_keygen_get() Did you see any other possibilty to fix this? --Gordon --7oN4/LC7dxEXkojl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmPt4fFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09zJjQf+MSMD8j40Nn6hGmgxwuNGOpo9er6v0pirxZw1DUHNs++ysKrOTHeysEyw nSYsXI5cVbgvGVUixuS77vzF44vZXVXLXgmaTSotscjVCrf1BKeL4RMBnmB7RxgW rdTt6EhwSC3tJo1BWOUrmff5C1Nauz2JN98cizFEMMJWKO9aYV8peWMc05eK4xL5 +5LRSTWenvrcoep0zevjHQYNKl8MoWP79Vv+2R5l+fEDxUOSOLAJwWrCQ3LBMHp2 POIlHDNF39xt2mXlHHZkkxM6cEtl1TDDUkej+es8/gEVyWKBmZV+LKTmUV0SfKWY 9EK+20i562ac3f61JhqH0uWuGQWngg== =MFqY -----END PGP SIGNATURE----- --7oN4/LC7dxEXkojl--