From owner-cvs-all@FreeBSD.ORG  Tue Jun  6 05:22:14 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3417216B3C1;
	Tue,  6 Jun 2006 04:50:32 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C52A243D46;
	Tue,  6 Jun 2006 04:50:31 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 24C03170DE;
	Tue,  6 Jun 2006 04:50:29 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.6/8.13.6) with ESMTP id k564oTsq025368;
	Tue, 6 Jun 2006 06:50:29 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Mon, 05 Jun 2006 21:13:22 -0000."
	<200606052113.k55LDMks055707@repoman.freebsd.org> 
Date: Tue, 06 Jun 2006 06:50:29 +0200
Message-ID: <25334.1149569429@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/geom geom.h geom_io.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2006 05:22:15 -0000

In message <200606052113.k55LDMks055707@repoman.freebsd.org>, Pawel Jakub Dawid
ek writes:

>  Add g_duplicate_bio() function which does the same thing what g_clone_bio()
>  is doing, but g_duplicate_bio() allocates new bio with M_WAITOK flag.

First, this sounds wrong to me from an overall memory management point
of view.

Second, g_clone_bio_wait() had been a better name.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.