From owner-svn-src-all@freebsd.org Tue Mar 20 05:58:53 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D318F5532F for ; Tue, 20 Mar 2018 05:58:53 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C7E1280E99 for ; Tue, 20 Mar 2018 05:58:52 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by mail-it0-x22c.google.com with SMTP id k79-v6so885886ita.2 for ; Mon, 19 Mar 2018 22:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jroberson-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=IHZtAcWWWKFsuEI4vvZFyIlkhMM9m3BLA4TCB4R0s5g=; b=B9KZ61oXAfE5l8Kq6zc6NQ6N1ri7a0e6xDyhWdNkuVmQSbmyZFU2Nez26WphOjlClC yayZI0YoijYFznaM8kh24v4NkWFgO0CXgcu97wMnhEypX607xT/WaKWz0deyN8O3P4Qb o0fmupEKKGoeSWVVcZXbUTRGxfUk7UBLsmKIyEVcvjf6jyLNTXn23ZOvInnBaG6/cgEw GiXeS+SYhn5w0al1H+Pz/auHTQJClE9TR6VdGxy2fcI6bQ/ul1DvjjLxOae7WHpIRi67 Xt9ABsimWkUK011jebsm2Sfzb2eZBR1t83p3UItKY6OYjSz41UbHwS86I+eHuQm/mvMd gZKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=IHZtAcWWWKFsuEI4vvZFyIlkhMM9m3BLA4TCB4R0s5g=; b=M0UGhPJwCExWy8NyQA4PzweV9Rk0OPlOWjoKZ8ieNJR46QsO1rWGloX7Mt4HSJLN/1 SwmOl/GXZ3A9odrTbFsvQpZ25b9K3FXGsvyKlaO9naYS3anzlWbLlxHisWkgPP/mJcdQ LvTqScp2nstO5feMwBSzuPXao4Xl8WzzqsWeFrARdHdohR8b5Fl1f2Dub8Sq42+RzX1z TiVh1EIpEd1OGeRzK0796nF4m4wnej5+tLl+PWypvg6EnD7DXh8BOkH2e7/r45iRI9tq 0aFSzOorNhkQ0QXzqBy/jNojeT3+Egq53st/xvEtmGIm9NeE07aqzYaJoraVSDHOeHrH DHPw== X-Gm-Message-State: AElRT7H7R3QpzzBWdJWz7h5JgL0F1SzqUS8U16MFKnluTBvdfqYTl9uN VEMnfTqMXAa1hhk4Ypt/idnptQ== X-Google-Smtp-Source: AG47ELv3sbN1xBm0m2hCUoijgIApQ+BXl4rNy/ezRg7qALtajzcboefyswJwgPQAY5TKbnTdSGXl3A== X-Received: by 2002:a24:d8f:: with SMTP id 137-v6mr1548227itx.30.1521525532141; Mon, 19 Mar 2018 22:58:52 -0700 (PDT) Received: from rrcs-66-91-135-210.west.biz.rr.com (rrcs-66-91-135-210.west.biz.rr.com. [66.91.135.210]) by smtp.gmail.com with ESMTPSA id y3-v6sm527872itg.3.2018.03.19.22.58.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Mar 2018 22:58:51 -0700 (PDT) Date: Mon, 19 Mar 2018 19:57:57 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Justin Hibbits cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331233 - head/sys/kern In-Reply-To: <201803200201.w2K21UgY079589@repo.freebsd.org> Message-ID: References: <201803200201.w2K21UgY079589@repo.freebsd.org> User-Agent: Alpine 2.21 (BSF 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 05:58:53 -0000 Thanks for fixing my bug. Sorry I didn't build universe for this one. Thanks, Jeff On Tue, 20 Mar 2018, Justin Hibbits wrote: > Author: jhibbits > Date: Tue Mar 20 02:01:30 2018 > New Revision: 331233 > URL: https://svnweb.freebsd.org/changeset/base/331233 > > Log: > Cast through uintptr_t to narrow the buf domain pointer on 32-bit archs > > arg2 is an intmax_t, which on 32-bit architectures is 64 bits, wider than a > pointer. When &bdomain[i] is added to arg2 it widens from uintptr_t to > intmax_t, then gcc whines when it gets cast to a pointer. Casting through > uintptr_t silences this warning. > > Modified: > head/sys/kern/vfs_bio.c > > Modified: head/sys/kern/vfs_bio.c > ============================================================================== > --- head/sys/kern/vfs_bio.c Tue Mar 20 01:33:04 2018 (r331232) > +++ head/sys/kern/vfs_bio.c Tue Mar 20 02:01:30 2018 (r331233) > @@ -435,7 +435,7 @@ sysctl_bufdomain_int(SYSCTL_HANDLER_ARGS) > return (error); > *(int *)arg1 = value; > for (i = 0; i < buf_domains; i++) > - *(int *)(((uintptr_t)&bdomain[i]) + arg2) = > + *(int *)(uintptr_t)(((uintptr_t)&bdomain[i]) + arg2) = > value / buf_domains; > > return (error); > @@ -454,7 +454,7 @@ sysctl_bufdomain_long(SYSCTL_HANDLER_ARGS) > return (error); > *(long *)arg1 = value; > for (i = 0; i < buf_domains; i++) > - *(long *)(((uintptr_t)&bdomain[i]) + arg2) = > + *(long *)(uintptr_t)(((uintptr_t)&bdomain[i]) + arg2) = > value / buf_domains; > > return (error); >