From owner-svn-src-head@FreeBSD.ORG Fri Dec 18 11:27:36 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32EB1106568B; Fri, 18 Dec 2009 11:27:36 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id DE9C88FC08; Fri, 18 Dec 2009 11:27:35 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id EEBA96D450; Fri, 18 Dec 2009 11:27:34 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id CC1BD84549; Fri, 18 Dec 2009 12:27:34 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: John Baldwin References: <200912161717.nBGHHeQZ005541@svn.freebsd.org> <200912161541.53834.jhb@freebsd.org> Date: Fri, 18 Dec 2009 12:27:34 +0100 In-Reply-To: <200912161541.53834.jhb@freebsd.org> (John Baldwin's message of "Wed, 16 Dec 2009 15:41:53 -0500") Message-ID: <868wd0cyjd.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2009 11:27:36 -0000 John Baldwin writes: > Warner Losh writes: > > Log: > > Fix compiling FREEBSD_COMPAT[4,5,6] without FREEBSD_COMPAT7. > >=20=20=20 > > Note: Not sure this is the right way to do compat, but it makes the > > headers consistent with the implementations. > Please revert. I think this has already been reverted once before. Yep, that was me... we concluded back then that this is a perfectly reasonable dependency; perhaps we should simply add the appropriate #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n) without FREEBSD_COMPAT(n+1). DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no