Date: Wed, 14 Aug 2013 09:25:15 +0200 From: Dimitry Andric <dim@freebsd.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Pedro F. Giffuni" <pfg@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r254286 - head/sys/fs/ext2fs Message-ID: <D7085899-43B9-4979-9A13-DEB0B37DBA15@freebsd.org> In-Reply-To: <CACVs6=_6rGa0inrz%2BOPc%2B61mObkwx3syQ4JQ6zctGin3JgW4DQ@mail.gmail.com> References: <201308131839.r7DIdaLD037277@svn.freebsd.org> <9B5BBD34-F953-40BF-8C10-0EF466ED3350@FreeBSD.org> <CACVs6=_6rGa0inrz%2BOPc%2B61mObkwx3syQ4JQ6zctGin3JgW4DQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 14, 2013, at 09:14, Juli Mallett <jmallett@FreeBSD.org> wrote: > On Wed, Aug 14, 2013 at 12:11 AM, Dimitry Andric <dim@freebsd.org> = wrote: > This still fails on arches where int64_t is aliased to long long > (basically, the 32-bit arches). Since using PRId64 is apparently > frowned upon, the easiest solution is to cast the 'start' and 'last' > variables to long long, and print them using %lld. >=20 > That can't be the easiest solution, it's not even that easy :) It = seems like intmax_t or uintmax_t as appropriate and cast to %jd or %ju = respectively would be better. I was simply looking at the surrounding code, and that already casts several items to long long. So I wanted to keep the style there. :-) -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D7085899-43B9-4979-9A13-DEB0B37DBA15>