Date: Tue, 2 Jul 2013 20:38:20 -0300 From: Felippe de Meirelles Motta <lippe@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r321982 - in head/net: . hanstunnel hanstunnel/files Message-ID: <CAJcxwRQe9rOw%2B%2BVL1_RV3ediT9fk5PJeVmYfbDaOQDB4GPuJBg@mail.gmail.com> In-Reply-To: <2F9D29C1-259B-41F0-9C67-00AAE5DBA69E@adamw.org> References: <201306282045.r5SKjaZb090161@svn.freebsd.org> <20130701011908.GB9325@FreeBSD.org> <CAJcxwRS73RvuYf1cYXMjzYktt44w_Bh=OvbZqtyELvYAxWC=1A@mail.gmail.com> <2F9D29C1-259B-41F0-9C67-00AAE5DBA69E@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I talked with other committers these days and I must admit that I was wrong, so I sent new patches for PRs that I am dealing with and if the submitter or maintainer does not reply, I can use the timeout for resolve these issues in a better way . Did not want to disrespect or offend anyone's and bsam@ and danfe@ comments were very well received by me and I see this as constructive criticism, just as you did it now. I know the efforts of those who are conducting a cleanup in CATEGORIES (e.g. OPTIONS). I think I include something wrong in these categories that have already been corrected, would be wrong. Thanks lippe@ On Tue, Jul 2, 2013 at 8:00 PM, Adam Weinberger <adamw@adamw.org> wrote: > On 2013-07-01, at 13:30, Felippe de Meirelles Motta <lippe@FreeBSD.org> > wrote: > > > danfe@, bsam@ and others thanks for the points mentioned, some I had > noticed, others I had really missed, but I just could not manipulate the > outcome of the patches without proper approval of the maintainer, because > this is your role. > > Sorry but I totally disagree. As committers, we (supposedly) know what is > best, and the right way to do things. External maintainers are submitters; > they can make mistakes and you can catch and fix them, within reason. On > the whole, people are quite appreciative when you commit their patch > quickly with small modifications, rather than dragging the PR for weeks > while you wait for a spelling fix. > > I mean, don't go changing the logic or anything, but all the time I close > PR's with "Committed, but I fixed MASTER_SITE to use the source forge > macro" or whatever. Never once have I heard anything except "Thank you," > and best of all, next time they submit a PR they get it right. > > I really don't understand why you'd rather commit something you know to be > wrong. DTRT and don't be a pedant. > > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > http://www.adamw.org > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJcxwRQe9rOw%2B%2BVL1_RV3ediT9fk5PJeVmYfbDaOQDB4GPuJBg>